NACK/Cmnt: [SRU][F][PATCH v1 0/1] UBUNTU: SAUCE: bluefield_edac: Add SMC support

[Stefan Bader]

On 19.02.21 06:10, Shravan Kumar Ramani wrote:

Subject should be "[SRU][F:linux-bluefield]..." or at least "[SRU][F:bluefield]..."

> BugLink: https://bugs.launchpad.net/chelmsford/+bug/1916107

The bug report must be a public bug report against the linux-bluefield source.

> 
> SRU Justification:
> 
> [Impact]
> The ACPI table entry for EDAC has been updated to enable secure calls.
> Without driver support for the same, all EMI register reads will return 0,
> and writes will have no effect.
> 
> [Fix]
> Add support for SMC in bluefield_edac.
> Secure calls are enabled/disabled in ACPI.
> 
> [Test case]
> Verified by injecting an ECC error to trigger an EDAC event.


Above template (with an additional [Regression Potential] section which explains
what might be visible outcomes if the change causes problems. what might go
wrong...) should be in the bug report description as well. Information in the
cover email is rather for reviewers of the patch. The bug report info is for
those handling the resulting kernel releases (actually any package updates).

> 
> Shravan Kumar Ramani (1):
>   UBUNTU: SAUCE: bluefield_edac: Add SMC support
> 
>  drivers/edac/bluefield_edac.c | 175 ++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 158 insertions(+), 17 deletions(-)
> 

Those who will be submitting patches on a regular base should subscribe to
kernel-team at lists.ubuntu.com. Otherwise each submission has to be moderated.

Thanks,
Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210219/71811dd3/attachment.sig>