ACK/Cmt: [X/B/F/G/H/Unstable][SRU][PATCH 0/1] DMI entry syntax fix for Pegatron / ByteSpeed C15B

[Po-Hsu Lin]

On Fri, Jan 8, 2021 at 3:21 PM William Breathitt Gray
<william.gray at canonical.com> wrote:
>
> On Fri, Jan 08, 2021 at 01:34:01PM +0800, Po-Hsu Lin wrote:
> > [Impact]
> > Upstream reports that when compiling the kernel with a48491c65b51
> > ("Input: i8042 - add ByteSpeed touchpad to noloop table"), g++ will
> > complain about:
> >     drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’
> >     designator used multiple times in the same initializer list
> >
> > C99 semantics is that last duplicated initialiser wins,
> > so DMI entry gets overwritten.
> >
> > [Fix]
> > * a3a9060ecad030 ("Input: i8042 - unbreak Pegatron C15B") in linux-next
> >
> > This can be cherry-picked into all the affected series.
> > Note that patch for bug 1906128 should be applied first.
> >
> > [Test]
> > I didn't get this error while building the test kernels for bug
> > 1906128 on builder kathleen, with fakeroot commands.
> >
> > So the only thing that I can test is to build them again and make
> > sure there is no other issues.
> >
> > [Where problems could occur]
> > If this fix is incorrect it might affect the touchpad support on
> > Pegatron / ByteSpeed C15B laptop.
> >
> > Alexey Dobriyan (1):
> >   Input: i8042 - unbreak Pegatron C15B
> >
> >  drivers/input/serio/i8042-x86ia64io.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > --
> > 2.7.4
>
> Acked-by: William Breathitt Gray <william.gray at canonical.com>
>
> By the way, if your patch requires prerequisite patches as you mention,
> please provide the `git patch-id --stable` patch ID for it; this helps
> make sure the patches are applied in the correct order. You can have
> `git format-patch` generate this automatically for you by using the
> `--base` option:
> https://git-scm.com/docs/git-format-patch#_base_tree_information
>

Oh! Didn't try this before.
Thanks for the info!
Sam

> William Breathitt Gray