NACK: [bionic:linux-azure-4.15][PATCH 1/1] UBUNTU: [Config] azure: Disable ATARI_PARTITION

[Marcelo Henrique Cerri]

On Thu, Jan 14, 2021 at 09:42:38AM -0800, Kamal Mostafa wrote:
> On Thu, Jan 14, 2021 at 01:46:07PM -0300, Marcelo Henrique Cerri wrote:
> > --- a/debian.azure-4.15/config/config.common.ubuntu
> > +++ b/debian.azure-4.15/config/config.common.ubuntu
> > @@ -262,7 +262,7 @@ CONFIG_ASYNC_XOR=m
> >  # CONFIG_AT803X_PHY is not set
> >  CONFIG_ATA=y
> >  CONFIG_ATALK=m
> > -CONFIG_ATARI_PARTITION=y
> > +CONFIG_ATARI_PARTITION=n
> >  CONFIG_ATA_ACPI=y
> >  CONFIG_ATA_BMDMA=y
> >  CONFIG_ATA_GENERIC=y
> 
> How come this one is not the usual "# CONFIG_WHATEVER is not set" format?

Now that you mentioned it, that looks wrong to me.

I manually set it to "n" and then ran `fakeroot debian/rules
udpateconfigs`. It seems that in those cases it doesn't update the
config to the above format. If I remove the config line and then
respond with "n" when updateconfigs asks about it, then I get
the commented line.

I will update the patches because I think that will cause problems in
the future.

> 
>  -Kamal

-- 
Regards,
Marcelo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210114/bbf84819/attachment.sig>