ACK: [SRU][Xenial][PATCH v2 0/3] Fix corruption on blocked_vcpu_on_cpu list

William Breathitt Gray william.gray at canonical.com
Thu Jan 14 23:11:49 UTC 2021


On Thu, Jan 14, 2021 at 03:21:41PM +0000, Ioanna Alifieraki wrote:
> Hi William,
> 
> Thanks for the feedback. Even with commit bc22512bb24c(kvm: vmx:
> rename vmx_pre/post_block to pi_pre/post_block)
> the patches still won't cherry-pick because upstream commit
> a0052191624e(kvm: vmx: check apicv is active before using VT-d posted
> interrupt) is missing, however the backport
> is cleaner and much simpler.

Okay, I see what you mean, this would have more dependencies than just
commit bc22512bb24c. Well if the backport is a better solution here,
then let's go with it.

Thanks,

Acked-by: William Breathitt Gray <william.gray at canonical.com>

> I'm happy to resubmit the patchset with commit bc22512bb24c(kvm: vmx:
> rename vmx_pre/post_block to pi_pre/post_block)
> included if it is a better option.
> 
> On Thu, Jan 7, 2021 at 8:36 AM William Breathitt Gray
> <william.gray at canonical.com> wrote:
> >
> > On Tue, Jan 05, 2021 at 11:54:57PM +0000, Ioanna Alifieraki wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/1908428
> > >
> > > The following 3 patches fix the bug reported in [1].
> > > They are backported to apply on 4.4 kernels.
> > > Backport is required becasue upstream commit
> > > bc22512bb24c(kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block)
> > > which renames  vmx_pre/post_block functions to pi_pre/post_block
> > > is missing from 4.4.
> > > Original patches come from [2] and have been accepted upstream.
> > >
> > > [1] https://marc.info/?l=kvm&m=149559827906211&w=2
> > > [2] https://lore.kernel.org/lkml/20170606105707.23207-1-pbonzini@redhat.com/
> > >
> > > Paolo Bonzini (3):
> > >   KVM: VMX: extract __pi_post_block
> > >   KVM: VMX: avoid double list add with VT-d posted interrupts
> > >   KVM: VMX: simplify and fix vmx_vcpu_pi_load
> > >
> > >  arch/x86/kvm/vmx.c | 177 ++++++++++++++++++++++-----------------------
> > >  1 file changed, 87 insertions(+), 90 deletions(-)
> > >
> > > --
> > > 2.17.1
> >
> > Upstream commit
> > bc22512bb24c(kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block)
> > looks pretty simple. If you pick that up first, then PATCH 1 and PATCH 2
> > can be cherry-picks right?
> >
> > William Breathitt Gray
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210114/69bd219f/attachment.sig>


More information about the kernel-team mailing list