ACK/Cmnt: [X/B/F/G/H/Unstable][SRU][PATCH 1/1] Input: i8042 - unbreak Pegatron C15B

[Stefan Bader]

On 08.01.21 06:34, Po-Hsu Lin wrote:
> From: Alexey Dobriyan <adobriyan at gmail.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1910639
> 
> g++ reports
> 
> 	drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list
> 
> C99 semantics is that last duplicated initialiser wins,
> so DMI entry gets overwritten.
> 
> Fixes: a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")
> Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>
> Acked-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
> Link: https://lore.kernel.org/r/20201228072335.GA27766@localhost.localdomain
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> (cherry picked from commit a3a9060ecad030e2c7903b2b258383d2c716b56c linux-next)
> Signed-off-by: Po-Hsu Lin <po-hsu.lin at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

As William already stated, referring to a pre-requisite somewhere in a cover
email indirectly by stating a bug number is rather pointless. IF it is the patch
mentioned in "Fixes:", then say so. If not, add at least an additional "Fixes"
(probably the git command mentioned by William does something like that, it
feels new so I have not tried yet myself). But in general, when looking at
patches on the mailing list one should not need to go on a wild hunt for info.

-Stefan

>  drivers/input/serio/i8042-x86ia64io.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 1f45010..e0176ba 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -223,6 +223,8 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "PEGATRON CORPORATION"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "C15B"),
>  		},
> +	},
> +	{
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ByteSpeed LLC"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "ByteSpeed Laptop C15B"),
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210119/0d917022/attachment.sig>