ACK/Cmnt: [SRU][F/G/H/U/OEM-5.10][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines
Stefan Bader
stefan.bader at canonical.com
Tue Jan 19 10:35:50 UTC 2021
On 07.01.21 18:48, Jeremy Szu wrote:
> * The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
> which is using 0x04 to control mute LED and 0x01 to control micmute LED.
>
> * The right channel speaker is no sound and it needs to expose GPIO1 for
> initialing AMP.
>
> Add quirks to support them.
>
> Signed-off-by: Jeremy Szu <jeremy.szu at canonical.com>
> Cc: <stable at vger.kernel.org>
> Link: https://lore.kernel.org/r/20210106130549.100532-1-jeremy.szu@canonical.com
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> (cherry picked from commit 91bc156817a3c2007332b64b4f85c32aafbbbea6
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: Jeremy Szu <jeremy.szu at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---
This is by now upstream (v5.11-rc4) same SHA1, so reference to alsa git as well
as SAUCE can be dropped when applying. Generally, can't we just wait until
things are at least in linux-next before doing a SRU? That would make things
much simpler.
-Stefan
> sound/pci/hda/patch_realtek.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 8616c5624870..f7a934d70db3 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7946,6 +7946,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x8780, "HP ZBook Fury 17 G7 Mobile Workstation",
> + ALC285_FIXUP_HP_GPIO_AMP_INIT),
> + SND_PCI_QUIRK(0x103c, 0x8783, "HP ZBook Fury 15 G7 Mobile Workstation",
> + ALC285_FIXUP_HP_GPIO_AMP_INIT),
> SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210119/04c170f4/attachment.sig>
More information about the kernel-team
mailing list