NACK/Cmnt: [PATCH v3 0/7][SRU][F] Support Advantech UNO-420 platform

[Stefan Bader]

On 19.01.21 08:01, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1902672
> 
> [Impact]
> There are some drivers are required to enable Advantech UNO-420 platform.
> 
> [Fix]
> Advantech is submitting their drivers to upstream for review, and
> considering that the patches are new drivers, it should be safe pull them
> back to ubuntu kernel.
> https://lkml.org/lkml/2021/1/18/500
> 
> [Test]
> Verified on Advantech UNO-420 platform.
> 
> [Where problems could occur]
> Those commits create 3 new drivers, and do not modify any existing drivers.
> Should introduce no regression.
> 
> v2 -> v3:
> 	SRU upstream v4 -> v6
> 
> Campion Kang (6):
>   UBUNTU: SAUCE: MAINTAINERS: Add Advantech AHC1EC0 embedded controller
>     entry
>   UBUNTU: SAUCE: mfd: ahc1ec0: Add Advantech EC include file used by
>     dt-bindings
>   UBUNTU: SAUCE: dt-bindings: mfd: ahc1ec0.yaml: Add Advantech embedded
>     controller - AHC1EC0
>   UBUNTU: SAUCE: mfd: ahc1ec0: Add support for Advantech embedded
>     controller
>   UBUNTU: SAUCE: hwmon: ahc1ec0-hwmon: Add sub-device hwmon for
>     Advantech embedded controller
>   UBUNTU: SAUCE: watchdog: ahc1ec0-wdt: Add sub-device watchdog for
>     Advantech embedded controller
> 
> Chia-Lin Kao (AceLan) (1):
>   UBUNTU: [Config] update config for Advantech devices
> 
>  .../devicetree/bindings/mfd/ahc1ec0.yaml      |  69 ++
>  MAINTAINERS                                   |  11 +
>  debian.master/config/config.common.ubuntu     |   3 +
>  drivers/hwmon/Kconfig                         |  10 +
>  drivers/hwmon/Makefile                        |   1 +
>  drivers/hwmon/ahc1ec0-hwmon.c                 | 660 ++++++++++++++
>  drivers/mfd/Kconfig                           |  10 +
>  drivers/mfd/Makefile                          |   2 +
>  drivers/mfd/ahc1ec0.c                         | 808 ++++++++++++++++++
>  drivers/watchdog/Kconfig                      |  11 +
>  drivers/watchdog/Makefile                     |   1 +
>  drivers/watchdog/ahc1ec0-wdt.c                | 261 ++++++
>  include/dt-bindings/mfd/ahc1ec0-dt.h          |  25 +
>  include/linux/mfd/ahc1ec0.h                   | 276 ++++++
>  14 files changed, 2148 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ahc1ec0.yaml
>  create mode 100644 drivers/hwmon/ahc1ec0-hwmon.c
>  create mode 100644 drivers/mfd/ahc1ec0.c
>  create mode 100644 drivers/watchdog/ahc1ec0-wdt.c
>  create mode 100644 include/dt-bindings/mfd/ahc1ec0-dt.h
>  create mode 100644 include/linux/mfd/ahc1ec0.h
> 
This looks mostly acceptable now, only a few minor changes (sent the details in
PM) should be needed.

Thanks,
Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210126/70578ab4/attachment-0001.sig>