NACK/Cmnt: [PATCH 0/3][SRU][F] Add a new hardware ID to intel-hid

[Stefan Bader]

On 26.01.21 21:20, Alex Hung wrote:
> 
> 
> On Tue, Jan 26, 2021 at 1:40 AM Stefan Bader <stefan.bader at canonical.com
> <mailto:stefan.bader at canonical.com>> wrote:
> 
>     On 26.01.21 07:43, Alex Hung wrote:
>     > On 2021-01-25 11:46 a.m., Marcelo Henrique Cerri wrote:
>     >> The changes look good to me, but why not target Groovy too? It seems
>     >> that G is missing the third patch.
>     >>
>     >
>     > Groovy doesn't have the HID for Rocket Lake (3rd patch), but Rocket Lake
>     > hardware may be officially available around the same time as Hirsute
>     > which can have both HIDs.
>     >
>     > Therefore, targeting Groovy is less valuable IMHO.
> 
>     But groovy 5.8 is the current hwe kernel for focal, so leaving it out is
>     inconsistent.
> 
> Is it preferred to send another SRU for G or fix and resend this SRU?

I think it is better to re-send for both series. That keeps things together and
more obvious (if the same patch applies to both it only needs to be there once).
Also a single thread per SRU is easier to follow.

-Stefan

> 
>  
> 
> 
>     -Stefan
> 
>     >
>     >> On Fri, Jan 22, 2021 at 07:14:51PM -0700, Alex Hung wrote:
>     >>> BugLink: https://bugs.launchpad.net/bugs/1907160
>     >>>
>     >>> [Impact]
>     >>>
>     >>>  intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms
>     because the existing
>     >>>  hardware ids "INT33D5" aren't used in BIOS.
>     >>>
>     >>> [Fix]
>     >>>
>     >>>  New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel
>     driver.
>     >>>
>     >>> [Test Case]
>     >>>
>     >>>  This was tested on a Rocket Lake platform and intel-hid was loaded
>     correctly as kernel log below:
>     >>>
>     >>>  [ 2.938964] input: Intel HID 5 button array as
>     /devices/platform/INT1054:00/input/input11
>     >>>
>     >>> [Where problems could occur]
>     >>>
>     >>>  None.
>     >>>
>     >>>  New IDs were added for new platforms. Previous platforms will not be
>     affected.
>     >>>
>     >>>  The patches were cherry-picked from upstream
>     >>>
>     >>>
>     >>> Alex Hung (1):
>     >>>   platform/x86: intel-hid: add Rocket Lake ACPI device ID
>     >>>
>     >>> Gayatri Kammela (2):
>     >>>   platform/x86: intel-hid: Add Tiger Lake ACPI device ID
>     >>>   platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
>     >>>
>     >>>  drivers/platform/x86/intel-hid.c | 2 ++
>     >>>  1 file changed, 2 insertions(+)
>     >>>
>     >>> --
>     >>> 2.25.1
>     >>>
>     >>> --
>     >>> kernel-team mailing list
>     >>> kernel-team at lists.ubuntu.com <mailto:kernel-team at lists.ubuntu.com>
>     >>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>     >>
>     >
>     >
> 
> 
> 
> 
> -- 
> Cheers,
> Alex Hung


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210127/6dca7e80/attachment-0001.sig>