ACK/Cmnt: [[SCRIPT=remove_re|Re: [PATCH 0/4[SRU][V2][F][G] Add a new hardware ID to intel-hid]]

[Stefan Bader]

On 27.01.21 23:21, Alex Hung wrote:
> BugLink: https://bugs.launchpad.net/bugs/1907160
> 
> [Impact]
> 
>  intel-hid is not loaded on Intel Tiger Lake and Rocket Lake platforms because the existing
>  hardware ids "INT33D5" aren't used in BIOS.
> 
> [Fix]
> 
>  New ids "INTC1051" and "INTC1054" are to be added to intel-hid kernel driver.
> 
> [Test Case]
> 
>  This was tested on a Rocket Lake platform and intel-hid was loaded correctly as kernel log below:
> 
>  [ 2.938964] input: Intel HID 5 button array as /devices/platform/INT1054:00/input/input11
> 
> [Where problems could occur]
> 
>  None.
> 
>  New IDs were added for new platforms. Previous platforms will not be affected.
> 
>  The patches were cherry-picked from upstream
> 
> [Note]
>  1. All 4 patch are required for Focal, and only patch 4 is required for Groovy
>  2. Patch 3 is required to create patch 4 for both F & G
> 
> Alex Hung (1):
>   platform/x86: intel-hid: add Rocket Lake ACPI device ID
> 
> Andy Shevchenko (1):
>   platform/x86: intel-hid: Move MODULE_DEVICE_TABLE() closer to the
>     table
> 
> Gayatri Kammela (2):
>   platform/x86: intel-hid: Add Tiger Lake ACPI device ID
>   platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
> 
>  drivers/platform/x86/intel-hid.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> --
> 2.25.1
> 
The changes themselves are ok, but you seem to have forgotten to add the BugLink
to the individual patches (can be done when applying, but for future
submissions). Apart from that the bug report was not correctly set up. To target
G and F you need specific tasks. The main task always refers to the current
development series (Hirsute or possibly unstable for the kernel). I have adapted
the bug as I thought it would be right. But the linux/development task needs
still a change depending on whether 5.11 already contains the change.


Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210128/59fdc18a/attachment-0001.sig>