ACK: [PATCH 1/1] HID: multitouch: Apply MT_QUIRK_CONFIDENCE quirk for multi-input devices

[Stefan Bader]

On 28.01.21 07:02, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1913520
> 
> Palm ejection stops working on some Elan and Synaptics touchpad after
> commit 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk for
> some devices").
> 
> The commit changes the mt_class from MT_CLS_WIN_8 to
> MT_CLS_WIN_8_FORCE_MULTI_INPUT, so MT_QUIRK_CONFIDENCE isn't applied
> anymore.
> 
> So also apply the quirk since MT_CLS_WIN_8_FORCE_MULTI_INPUT is
> essentially MT_CLS_WIN_8.
> 
> Fixes: 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk for some devices")
> Cc: stable at vger.kernel.org
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires at redhat.com>
> (cherry picked from commit 794c613383433ffc4fceec8eaa081b9f1962e287 linux-next)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

The comment I have is not so much about this specific patch but generally the
class of input device changes. Maybe it is just a feeling but my impression from
glancing over the summaries of incoming bug reports there seemed to be a number
of xy input stopped working ones. I understand that those are hard to avoid
whenever there is change. Just wondering whether someone is watching out for
specific failures like this in the incoming bug report?

Thanks,
Stefan

>  drivers/hid/hid-multitouch.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 0743ef51d3b2..8429ebe7097e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -758,7 +758,8 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  			MT_STORE_FIELD(inrange_state);
>  			return 1;
>  		case HID_DG_CONFIDENCE:
> -			if (cls->name == MT_CLS_WIN_8 &&
> +			if ((cls->name == MT_CLS_WIN_8 ||
> +			     cls->name == MT_CLS_WIN_8_FORCE_MULTI_INPUT) &&
>  				(field->application == HID_DG_TOUCHPAD ||
>  				 field->application == HID_DG_TOUCHSCREEN))
>  				app->quirks |= MT_QUIRK_CONFIDENCE;
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210128/f46912ea/attachment.sig>