ACK/Cmnt: [SRU][PATCH v4][F/oracle][PULL] arm64 support (LP: #1925421)

[Juerg Haefliger]

On Fri, 30 Apr 2021 12:46:16 -0600
Tim Gardner <tim.gardner at canonical.com> wrote:

> Acked-by: Tim Gardner <tim.gardner at canonical.com>
> 
> This works, but I think a good way to have addressed Juergh's concerns 
> about bisectability is to squash the 3 config commits into the opening 
> commit. At least that is how I've opened kernels in the past. The 
> history of how you arrived at the packaging changes isn't really 
> interesting. Besides, bisecting a derivative is a PITA anyways.

What you ideally want is to run genconfigs after every commit that you apply.
So that config and annotation changes come right after the commit that cause
those changes. But yes, bisecting derivatives is a pain and that makes it only
slightly less painful.

...Juerg


> Here is an example of the squashed config commits:
> 
> https://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/focal-1 
> Ubuntu-oracle-5.4.0-1045.48-arm64-review
> 
> I scattered some ignores into the ABI directory just to make sure cranky 
> open/close are gonna work. This builds OK, so I'm assuming you've done 
> some boot and stress testing ?
> 
> rtg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210501/5c7d57f5/attachment.sig>