NAK [SRU][F:linux-bluefield][PATCH 2/2] netfilter: flowtable: Make nf_flow_table_offload_add/del_cb inline

[Daniel Jurgens]

Hi Krzysztof, We don't see these patches in the kernel build that we received. Was there a reason they weren't taken?



> From: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> Sent: Tuesday, May 11, 2021 1:20 PM
> Subject: Re: NAK [SRU][F:linux-bluefield][PATCH 2/2] netfilter: flowtable:
> Make nf_flow_table_offload_add/del_cb inline
> 
> On 11/05/2021 14:12, Daniel Jurgens wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> >> Sent: Tuesday, May 11, 2021 1:04 PM
> >> On 11/05/2021 14:02, Daniel Jurgens wrote:
> >>> From: Alaa Hleihel <alaa at mellanox.com>
> >>>
> >>> BugLink: https://bugs.launchpad.net/bugs/1927246
> >>>
> >>> Currently, nf_flow_table_offload_add/del_cb are exported by
> >>> nf_flow_table module, therefore modules using them will have
> >>> hard-dependency on nf_flow_table and will require loading it all the
> time.
> >>>
> >>> This can lead to an unnecessary overhead on systems that do not use
> >>> this API.
> >>>
> >>> To relax the hard-dependency between the modules, we unexport
> these
> >>> functions and make them static inline.
> >>>
> >>> Fixes: 978703f42549 ("netfilter: flowtable: Add API for registering
> >>> to flow table events")
> >>> Signed-off-by: Alaa Hleihel <alaa at mellanox.com>
> >>> Reviewed-by: Roi Dayan <roid at mellanox.com>
> >>> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
> >>> Signed-off-by: David S. Miller <davem at davemloft.net> (backported
> >>> from commit 505ee3a1cab96785fbc2c7cdb41ab677ec270c3c)
> >>> Signed-off-by: Daniel Jurgens <danielj at nvidia.com>
> >>>
> >>> Conflicts:
> >>> 	net/netfilter/nf_flow_table_core.c
> >>> ---
> >>>  include/net/netfilter/nf_flow_table.h | 49
> >> ++++++++++++++++++++++++++++++++---
> >>>  net/netfilter/nf_flow_table_core.c    | 44 -------------------------------
> >>>  2 files changed, 45 insertions(+), 48 deletions(-)
> >>>
> >>
> >> You were too fast with v2. :)
> >> See my comments for second patch in v1.
> >>
> >
> > Couple more with conflicts: tag coming your way. I'll start removing those.
> Let me know if you want me to resend, or if you just want to drop when
> merging them.
> 
> I am fine with stripping them while applying, so no need for resend.
> 
> Best regards,
> Krzysztof