NACK/Cmnt: [PATCH 0/2][H/U/OEM-5.10/OEM-5.13] Fix Intel AC9560 BT function cannot turn on if BT turn off before S3 entry

[Stefan Bader]

On 23.09.21 03:21, Koba Ko wrote:
> On Wed, Sep 22, 2021 at 9:10 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>>
>> On 26.08.21 08:03, Koba Ko wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1941696
>>>
>>> Impact]
>>> 1. On Troy JSL platform, add AC9560
>>> 2. Enter Settings -> Bluetooth menu
>>> 3. Default Bluetooth option is ON, try to toggle the BT option to OFF
>>> 4. Into suspend mode(S3) and resume the system
>>> 5. Enter BT settings and try to turn on BT,
>>> 6. BT function cannot enabled until reboot.
>>>
>>> [Fix]
>>> Turn off the msft ext only for AC9560.
>>> Maintainer thought Intel should take care this and reject this workaround.
>>> https://marc.info/?l=linux-bluetooth&m=162938546804458&w=2
>>>
>>> Intel is working on this issue and sru the workaround for the schedule.
>>
>> What is the status of the proper fix for this?
> 
> Intel didn't propose a fix.
> The issue is caused by this 0ea9fd001a
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/bluetooth/hci_core.c?id=0ea9fd001a14ebc294f112b0361a4e601551d508)

^This patch got reverted in upstream stable and will be included in the current 
cycle. (5.11.0-37.41)

> The fix was upstreamed.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/net/bluetooth/hci_core.c?id=0ea53674d07fb6db2dd7a7ec2fdc85a12eb246c2

For Hirsute you will need to re-submit both of those patches (due to the 
revert). The submission here does no longer be valid.

-Stefan

> 
> 
>>
>> -Stefan
>>>
>>> [Test]
>>> Verified with the bellow steps 10 times.
>>> 1. On Troy JSL and add AC9560
>>> 2. Turn off BT
>>> 3. suspend&resume the machine 10 times.
>>> 4. turn on BT and works well.
>>>
>>> [Regression Potential]
>>> Medium, it's a workaround to turn off the MSFT ext only for ac9560.
>>>
>>>
>>> Koba Ko (1):
>>>     Bluetooth: btusb: add a reject table to disable msft
>>>
>>> Miao-chen Chou (1):
>>>     Bluetooth: btusb: Enable MSFT extension for Intel controllers
>>>
>>>    drivers/bluetooth/btusb.c | 13 ++++++++++++-
>>>    1 file changed, 12 insertions(+), 1 deletion(-)
>>>
>>
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210923/2a7f1b19/attachment.sig>