Fwd: [PATCH 0/1][SRU][Unstable/OEM-6.0/Kinectic] ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook

[Stefan Bader]

On 06.12.22 10:52, Andy Chi wrote:
> Hi Stefan,
> 
> 
> On 12/6/22 16:41, Stefan Bader wrote:
>> On 06.12.22 08:14, Andy Chi wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1998882
>>
>> Bug report is not completely filled in. No oem-6.0 task and no nominations for 
>> expected series.
> Seems like I don't have permission to tag series on the bug.

Ok, there should be at least AceLan and Timo who should be able. For this time I 
did it.

>>
>>>
>>> [Impact]
>>> The mic mute/audio mute LEDS are not work on HP ProBook Notebook PC
>>>
>>> [Fix]
>>> It needs the specific quirk for the hardware layout.
>>> Thus, add the quirks to make it works.
>>
>> Were both variants test-built?
>>
> Yes.
>>>
>>> [Test]
>>> After applying the quirk, the audio/mic mute LEDs are working good.
>>
>> Which kernel was tested?
> I tested with linux-sound tree.
>>
>> Please update the bug report and provide missing information as a follow-up to 
>> this thread.
> 
> This PC is still under developing by ODM, so it might reveal confidential 
> information by apport-bug.
> 
> Is it acceptable that not upload such information on this bug like Bug #1970178 
> <https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1970178>?

For a SRU submission I would minimally expect a successful test with the oem-6.0 
kernel as a proof that this really is a fix. And it just needs that statement, 
no detailed info about the hardware.

-Stefan

> 
>>
>> -Stefan
>>
>>>
>>> [Where problems could occur]
>>> If HP ships the different system boards design with the same subsystem ID of 
>>> audio codec which is using different GPIO pins (different layout), then the 
>>> quirk will not work (LEDs will not work when muting audio-output or microphone).
>>>
>>> Andy Chi (1):
>>>    ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook
>>>
>>>   sound/pci/hda/patch_realtek.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20221206/5f33bd85/attachment.sig>