ACK/Cmnt: [PATCH 0/2] [focal/impish/jammy linux-azure] Add sunrpc module parameters for NFSv3 nconnect

[Stefan Bader]

On 25.01.22 14:54, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1958990
> 
> SRU Justification
> 
> [Impact]
> 
> Microsoft has requested the addition of 2 module parameters to sunrpc.
> The primary purpose of which is to restrict or pin NFSv3 TCP connections
> to one server in order to take advantage of local server connection caching.
> In the presence of a load balancer, round robin connection requests defeats
> the advantages of local caching.
> 
> This patch also fixes a race condition when setting RPC message values and
> adding a client connection to the task list. Before, client connections were
> added to the task list before the associated RPC message was fully setup.
> 
> With the author's permission I have changed the default value of enable_azure_nconnect
> to false in order to preserve the original logic of this module with the exception
> of the above mentioned race condition.
> 
> [Test Plan]
> 
> Microsoft tested
> 
> [Where things could go wrong]
> 
> NFSv3 connection attempts could be slow or fail altogether.
> 
> [Other Info]
> 
> SF: #00312346
> 
> 

Just as a note, right now, depending on how soon azure rolls from 5.11 to 5.13 
in focal, all azure specific changes would have to consider focal:linux-azure-5.11.

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220126/2f619991/attachment-0001.sig>