ACK/Cmnt: [SRU][F:linux-bluefield][PATCH v2 0/1] UBUNTU: SAUCE: Fix references to sprintf that may cause buffer overflow

[Tim Gardner]

Acked-by: Tim Gardner <tim.gardner at canonical.com>

It is customary to describe the differences from v1 -- >v2, etc.

On 1/27/22 9:16 AM, Jitendra Lanka wrote:
> BugLink: https://bugs.launchpad.net/bugs/1959119
> 
> SRU Justification:
> 
> [Impact]
> Fix references to sprintf that have a possibility for buffer overflow
> 
> [Fix]
> Replace sprintf with snprintf containing a defined boundary of PAGE_SIZE for sysfs store/show functions and max array size defined otherwise.
> 
> [Test Case]
> Existing testcases should work as is as no functional change has been introduced by this patch.
> 
> [Regression Potential]
> Regression potential can be considered minimal since the patch does not change any function of the driver other than limiting the upper bound of sprintf where the usual lengths parsed are < PAGE_SIZE and requests > PAGE_SIZE are limited.
> 
> 
> Jitendra Lanka (1):
>    Fix references to sprintf that may cause buffer overflow
> 
>   drivers/platform/mellanox/mlxbf-pmc.c | 17 ++++++++++-------
>   1 file changed, 10 insertions(+), 7 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc