NAK Re: ACK/Cmnt: [PATCH 00/15][SRU][J][V2] AMD ACP 6.x DMIC Supports

Timo Aaltonen tjaalton at ubuntu.com
Tue Jul 5 13:38:57 UTC 2022


Hui, could you send this again as a pull-req instead?


Timo Aaltonen kirjoitti 5.7.2022 klo 10.27:
> Timo Aaltonen kirjoitti 24.3.2022 klo 12.49:
>> Tim Gardner kirjoitti 12.1.2022 klo 19.00:
>>> Acked-by: Tim Gardner <tim.gardner at canonical.com>
>>>
>>> What are the V2 differences ? You left that out of your cover letter.
>>
>> Alex is gone, but I think the only diff is that this is targeted for 
>> jammy now.
> 
> Ping, this is getting old now and upgrades from oem-5.14 to hwe-5.15 
> would regress because of this still not merged.
> 
> 
>>> On 1/6/22 11:41 AM, Alex Hung wrote:
>>>> BugLink: https://bugs.launchpad.net/bugs/1949245
>>>>
>>>> [Impact]
>>>>
>>>>    AMD's Yellow carp platforms will have an updated ACP IP block 
>>>> (ACP 6.x)
>>>>    which will not work with existing ACP drivers.
>>>>
>>>> [Fix]
>>>>
>>>>    Backport the new driver that is now in linux 5.16
>>>>
>>>> [Test]
>>>>
>>>>    This is requested by AMD.
>>>>
>>>> [Where problems could occur]
>>>>
>>>>    Low risk. This is a stand-alone driver that does not affect 
>>>> others devices
>>>>    and platforms.
>>>>
>>>>
>>>> Alex Hung (1):
>>>>    UBUNTU: [Config] Enable AMD ACP 6 DMIC Support
>>>>
>>>> Dan Carpenter (1):
>>>>    ASoC: amd: fix uninitialized variable in snd_acp6x_probe()
>>>>
>>>> Vijendar Mukunda (13):
>>>>    ASoC: amd: add Yellow Carp ACP6x IP register header
>>>>    ASoC: amd: add Yellow Carp ACP PCI driver
>>>>    ASoC: amd: add acp6x init/de-init functions
>>>>    ASoC: amd: add platform devices for acp6x pdm driver and dmic driver
>>>>    ASoC: amd: add acp6x pdm platform driver
>>>>    ASoC: amd: add acp6x irq handler
>>>>    ASoC: amd: add acp6x pdm driver dma ops
>>>>    ASoC: amd: add acp6x pci driver pm ops
>>>>    ASoC: amd: add acp6x pdm driver pm ops
>>>>    ASoC: amd: enable Yellow carp acp6x drivers build
>>>>    ASoC: amd: create platform device for acp6x machine driver
>>>>    ASoC: amd: add YC machine driver using dmic
>>>>    ASoC: amd: enable Yellow Carp platform machine driver build
>>>>
>>>>   debian.master/config/config.common.ubuntu |   2 +
>>>>   sound/soc/amd/Kconfig                     |  21 ++
>>>>   sound/soc/amd/Makefile                    |   1 +
>>>>   sound/soc/amd/yc/Makefile                 |   9 +
>>>>   sound/soc/amd/yc/acp6x-mach.c             | 194 +++++++++++++
>>>>   sound/soc/amd/yc/acp6x-pdm-dma.c          | 448 
>>>> ++++++++++++++++++++++++++++++
>>>>   sound/soc/amd/yc/acp6x.h                  | 107 +++++++
>>>>   sound/soc/amd/yc/acp6x_chip_offset_byte.h | 444 
>>>> +++++++++++++++++++++++++++++
>>>>   sound/soc/amd/yc/pci-acp6x.c              | 339 
>>>> ++++++++++++++++++++++
>>>>   9 files changed, 1565 insertions(+)
>>>>   create mode 100644 sound/soc/amd/yc/Makefile
>>>>   create mode 100644 sound/soc/amd/yc/acp6x-mach.c
>>>>   create mode 100644 sound/soc/amd/yc/acp6x-pdm-dma.c
>>>>   create mode 100644 sound/soc/amd/yc/acp6x.h
>>>>   create mode 100644 sound/soc/amd/yc/acp6x_chip_offset_byte.h
>>>>   create mode 100644 sound/soc/amd/yc/pci-acp6x.c
>>>>
>>>
>>
>>
> 
> 


-- 
t



More information about the kernel-team mailing list