NACK/Cmnt: [SRU] [J/OEM-5.14] [PATCH 0/1] Fix PSR flickers on Intel TGL laptops + AUO panel

[Stefan Bader]

On 06.07.22 09:30, Kai-Heng Feng wrote:
> On Tue, Jul 5, 2022 at 4:47 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>>
>> On 28.06.22 14:15, Kai-Heng Feng wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1980087
>>>
>>> [Impact]
>>> Screen flickers on certain Intel TGL laptops + AUO panel.
>>>
>>> [Fix]
>>> Enable PSR2 selective fetch only for the specific case to minimize the
>>> regression risk.
>>>
>>> [Test]
>>> Screen flickers can no longer be observed on affected laptops.
>>>
>>> [Where problems could occur]
>>> The fix becomes very specific, so any other combination won't be affected at
>>> all.
>>>
>>> Kai-Heng Feng (1):
>>>     UBUNTU: SAUCE: drm/i915/display/psr: Fix flicker on TGL + AUO panel
>>>
>>>    drivers/gpu/drm/i915/display/intel_dp.c  |  2 +-
>>>    drivers/gpu/drm/i915/display/intel_dp.h  |  2 ++
>>>    drivers/gpu/drm/i915/display/intel_psr.c | 11 +++++++++++
>>>    3 files changed, 14 insertions(+), 1 deletion(-)
>>>
>>
>> This is not upstream, thus cannot considered as a SRU.
> 
> It's either this quirk with very limited scope, or massive i915 PSR
> backport with known regression risk.
> 
> So no, this is not in upstream, but it's still much better than the
> alternative as SRU material.

Then please re-submit and clearly (and best have that as part of the SAUCE 
commit message AND refer to that in the cover email). We get that many requests 
that special reasons need to stick out well. And we better have some reminders 
in the only place that will persist. For Jammy this is no longer relevant but if 
this were for the devel kernel at a time before release but when no longer going 
for the latest kernel, the commit could also contain a hint that it can be 
dropped after kernel vX.Y. As said not for this time but we urgently need to 
improve our tracking why something was decided that way-

-Stefan

> 
> Kai-Heng
> 
>>
>> -Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220706/c0356ec7/attachment.sig>