ACK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: pwr-mlxbf.c: make hids local variables

Tim Gardner tim.gardner at canonical.com
Wed Jul 6 11:19:34 UTC 2022


On 7/5/22 14:16, Asmaa Mnebhi wrote:
> Buglink: https://bugs.launchpad.net/bugs/1980774
> 
> SRU Justification:
> 
> [Impact]
> 
> Both rst_pwr_hid and low_pwr_hid are only used in a single function so they should be local variables.
> 
> [Fix]
> 
> * Move rst_pwr_hid and low_pwr_hid to pwr_mlxbf_irq
> 
> [Test Case]
> 
> * build without warnings
> * pwr-mlxbf.c is loaded successfully
> * reset via BMC GPIO is successful
> 
> [Regression Potential]
> 
> Any of the test cases above could be impacted due to these changes.
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list