ACK/Cmnt: [SRU][Jammy][Pull Request] AMD ACP 6.x DMIC Supports

[Stefan Bader]

On 06.07.22 06:18, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1949245
> 
> [Impact]
> 
>    AMD's Yellow carp platforms will have an updated ACP IP block (ACP 6.x)
>    which will not work with existing ACP drivers.
> 
> [Fix]
> 
>    Backport the new driver that is now in linux 5.16
> 
> [Test]
> 
>    Boot the patched kernel on the lenovo amd yc machines, we could see
>    the internal mic could be detected and be listed in the sound-setting.
> 
> [Where problems could occur]
> 
>    Low risk. This is a stand-alone driver that does not affect others devices
>    and platforms.
> 
> 
> The following changes since commit 4ac8bd45a3f2192fad2cdc6fecc8a7ebbfe17d5c:
> 
>    Merge branch 'master-next' of 
> git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/jammy into 
> master-next (2022-07-04 20:18:11 +0800)
> 
> are available in the Git repository at:
> 
> git://git.launchpad.net/~hui.wang/ubuntu/+source/linux/+git/jammy-1 lp1949245
> 
> for you to fetch changes up to 8b1d444e137d4ed62a7dcef924ad9af20afbdee6:
> 
>    UBUNTU: [Config] Enable AMD ACP 6 DMIC Support (2022-07-06 11:30:28 +0800)
> 
> ----------------------------------------------------------------
> Dan Carpenter (1):
>        ASoC: amd: fix uninitialized variable in snd_acp6x_probe()
> 
> Hui Wang (1):
>        UBUNTU: [Config] Enable AMD ACP 6 DMIC Support
> 
> Vijendar Mukunda (13):
>        ASoC: amd: add Yellow Carp ACP6x IP register header
>        ASoC: amd: add Yellow Carp ACP PCI driver
>        ASoC: amd: add acp6x init/de-init functions
>        ASoC: amd: add platform devices for acp6x pdm driver and dmic driver
>        ASoC: amd: add acp6x pdm platform driver
>        ASoC: amd: add acp6x irq handler
>        ASoC: amd: add acp6x pdm driver dma ops
>        ASoC: amd: add acp6x pci driver pm ops
>        ASoC: amd: add acp6x pdm driver pm ops
>        ASoC: amd: enable Yellow carp acp6x drivers build
>        ASoC: amd: create platform device for acp6x machine driver
>        ASoC: amd: add YC machine driver using dmic
>        ASoC: amd: enable Yellow Carp platform machine driver build
> 
>   debian.master/config/annotations          |   4 ++
>   debian.master/config/config.common.ubuntu |   2 +
>   sound/soc/amd/Kconfig                     |  21 +++++++
>   sound/soc/amd/Makefile                    |   1 +
>   sound/soc/amd/yc/Makefile                 |   9 +++
>   sound/soc/amd/yc/acp6x-mach.c             | 194 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   sound/soc/amd/yc/acp6x-pdm-dma.c          | 448 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 
> 
>   sound/soc/amd/yc/acp6x.h                  | 107 ++++++++++++++++++++++++++++++++
>   sound/soc/amd/yc/acp6x_chip_offset_byte.h | 444 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 
> 
>   sound/soc/amd/yc/pci-acp6x.c              | 339 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 
> 
>   10 files changed, 1569 insertions(+)
>   create mode 100644 sound/soc/amd/yc/Makefile
>   create mode 100644 sound/soc/amd/yc/acp6x-mach.c
>   create mode 100644 sound/soc/amd/yc/acp6x-pdm-dma.c
>   create mode 100644 sound/soc/amd/yc/acp6x.h
>   create mode 100644 sound/soc/amd/yc/acp6x_chip_offset_byte.h
>   create mode 100644 sound/soc/amd/yc/pci-acp6x.c
> 
> 
The submitted form looks good to me. Specifying the merge commit as the start 
SHA1 I get exactly the relevant patches. They apply and are isolated into new 
specific driver modules. They also were pending to be going in before release 
but were lost. So it can be as much considered bug fix than feature addition.

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220708/2f2672c1/attachment.sig>