ACK/Cmnt: [SRU][J][PATCH 0/1] net: openvswitch: fix misuse of the cached connection on tuple changes

Stefan Bader stefan.bader at canonical.com
Fri Jul 8 09:41:53 UTC 2022


On 06.07.22 14:36, Frode Nordahl wrote:
> Buglink: https://launchpad.net/bugs/1967856
> 
> SRU Justification:
> 
> [Impact]
> 
> Users of Open vSwitch on Jammy will be affected by this bug and
> have no user space fix available.  This bug currently blocks the
> OpenStack Engineering team's charm product gate.
> 
> [Fix]
> 
> * cba7c76ea1e15fddb95706eb64659644a6a02b38 "net: openvswitch: fix
> misuse of the cached connection on tuple changes"
> 
> [Test Plan]
> 
> A reproducer has been attached to the bug and can be executed with
> the OVS system testsuite.
> 
> [Where problems could occur]
> 
> The regression potential can be considered as low because:
> - The calls added in the openvswitch kernel datapath code would
>    prior to Open vSwitch 2.16.0 have been initiated from the
>    userspace code and by chance concealed this bug.
> - After an optimization done in 2.16.0 the kernel bug was
>    revealed and these calls now must be made from the kernel
>    datapath to retain functionality in use in the wild.
> 
As Tim mentioned as well, Impish goes EOL soon and there is no updated kernel 
planned, so we ignore that part.

Just as an advice for future submissions: if you export the first patch (or set 
of patches) with --cover-letter and then additional patches/sets without but 
with --start-number= you can avoid unnecessary repeated 0/1 elements.


Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220708/44ab1172/attachment-0001.sig>


More information about the kernel-team mailing list