NAK: [SRU][J/allwinner-5.17][PATCH 0/4] Fix more Allwinner D1 drivers

[Emil Renner Berthing]

On Fri, 8 Jul 2022 at 14:40, Tim Gardner <tim.gardner at canonical.com> wrote:
>
> On 7/8/22 04:50, Emil Renner Berthing wrote:
> > [Impact]
> >
> >   * The drivers for the display engine, crypto acceleration and USB
> >     don't probe because of missing dependencies.
> >
> > [Test Plan]
> >
> >   * Boot the kernel in linux-image-5.17.0-1002-allwinner and see
> >     /sys/kerne/debug/devices_deferred
> >
> > [Where problems could occur]
> >
> >   * Fixing this may introduce now bugs if the now probing drivers
> >     turn out to be buggy.
> >
> > Andre Przywara (1):
> >    phy: sun4i-usb: Rework HCI PHY (aka "pmu_unk1") handling
> >
> > Emil Renner Berthing (1):
> >    UBUNTU: [Config] Enable additional Allwinner D1 options
> >
> > Samuel Holland (2):
> >    UBUNTU: SAUCE: phy: sun4i-usb: Add D1 variant
> >    UBUNTU: SAUCE: PM / devfreq: Add dummy R329/D1 MBUS driver
> >
> >   debian.allwinner/config/config.common.ubuntu |  5 ++-
> >   drivers/devfreq/Kconfig                      |  6 +++
> >   drivers/devfreq/Makefile                     |  1 +
> >   drivers/devfreq/sun50i-r329-mbus.c           | 27 +++++++++++++
> >   drivers/phy/allwinner/phy-sun4i-usb.c        | 40 +++++++++++---------
> >   5 files changed, 60 insertions(+), 19 deletions(-)
> >   create mode 100644 drivers/devfreq/sun50i-r329-mbus.c
> >
>
> When backporting, don't forget the description of the steps you took. In
> this case it looks like it was simple context adjustments in patch 1/1.

I'm sorry I don't know what you mean by this. Do you mean describe the
steps I took produce the error? Eg. install the allwinner kernel and
look at /sys/kernel/debug/devices_deferred?

Context adjustments? Patch 1/1 is a cherry-pick from mainline and it
applied cleanly.

> Where are the annotation updates for the config changes in patch 4/4 ?

I ran cranky updateconfigs and it didn't complain, so I guess these
options weren't annotated. Should I add annotations for all of them or
just the option added in patch 3/4?

/Emil


> rtg
>
> --
> -----------
> Tim Gardner
> Canonical, Inc