[PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support

Kai-Heng Feng kai.heng.feng at canonical.com
Mon Jul 11 00:28:10 UTC 2022


On Sat, Jul 9, 2022 at 12:00 AM PaddyKP_Yao <ispaddy at gmail.com> wrote:
>
> In some new ASUS devices, hotkey Fn+F13 is used for mic mute. If mic-mute
> LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
> mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
> it. The binding of mic-mute LED controls will be swithched with LED
> trigger.
>
> Signed-off-by: PaddyKP_Yao <PaddyKP_Yao at asus.com>

Wrong mailing list?
The correct address is 'platform-driver-x86 at vger.kernel.org'.

Kai-Heng

> ---
>  drivers/platform/x86/Kconfig               |  2 ++
>  drivers/platform/x86/asus-wmi.c            | 25 ++++++++++++++++++++++
>  include/linux/platform_data/x86/asus-wmi.h |  1 +
>  3 files changed, 28 insertions(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index f915cf67aa26..74769050b770 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -274,6 +274,8 @@ config ASUS_WMI
>         select INPUT_SPARSEKMAP
>         select LEDS_CLASS
>         select NEW_LEDS
> +       select LEDS_TRIGGERS
> +       select LEDS_TRIGGER_AUDIO
>         select ACPI_PLATFORM_PROFILE
>         help
>           Say Y here if you have a WMI aware Asus laptop (like Eee PCs or new
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index e14fb5fa7324..40c0e00a4b71 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -191,6 +191,7 @@ struct asus_wmi {
>         int kbd_led_wk;
>         struct led_classdev lightbar_led;
>         int lightbar_led_wk;
> +       struct led_classdev micmute_led;
>         struct workqueue_struct *led_workqueue;
>         struct work_struct tpd_led_work;
>         struct work_struct wlan_led_work;
> @@ -906,12 +907,23 @@ static enum led_brightness lightbar_led_get(struct led_classdev *led_cdev)
>         return result & ASUS_WMI_DSTS_LIGHTBAR_MASK;
>  }
>
> +static int micmute_led_set(struct led_classdev *led_cdev,
> +                          enum led_brightness brightness)
> +{
> +       int state = brightness != LED_OFF;
> +       int err;
> +
> +       err = asus_wmi_set_devstate(ASUS_WMI_DEVID_MICMUTE_LED, state, NULL);
> +       return err < 0 ? err : 0;
> +}
> +
>  static void asus_wmi_led_exit(struct asus_wmi *asus)
>  {
>         led_classdev_unregister(&asus->kbd_led);
>         led_classdev_unregister(&asus->tpd_led);
>         led_classdev_unregister(&asus->wlan_led);
>         led_classdev_unregister(&asus->lightbar_led);
> +       led_classdev_unregister(&asus->micmute_led);
>
>         if (asus->led_workqueue)
>                 destroy_workqueue(asus->led_workqueue);
> @@ -983,6 +995,19 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
>                                            &asus->lightbar_led);
>         }
>
> +       if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
> +               asus->micmute_led.name = "asus::micmute";
> +               asus->micmute_led.max_brightness = 1;
> +               asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
> +               asus->micmute_led.brightness_set_blocking = micmute_led_set;
> +               asus->micmute_led.default_trigger = "audio-micmute";
> +
> +               rv = led_classdev_register(&asus->platform_device->dev,
> +                                               &asus->micmute_led);
> +               if (rv)
> +                       goto error;
> +       }
> +
>  error:
>         if (rv)
>                 asus_wmi_led_exit(asus);
> diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
> index 17dc5cb6f3f2..38ee75874d11 100644
> --- a/include/linux/platform_data/x86/asus-wmi.h
> +++ b/include/linux/platform_data/x86/asus-wmi.h
> @@ -49,6 +49,7 @@
>  #define ASUS_WMI_DEVID_LED4            0x00020014
>  #define ASUS_WMI_DEVID_LED5            0x00020015
>  #define ASUS_WMI_DEVID_LED6            0x00020016
> +#define ASUS_WMI_DEVID_MICMUTE_LED             0x00040017
>
>  /* Backlight and Brightness */
>  #define ASUS_WMI_DEVID_ALS_ENABLE      0x00050001 /* Ambient Light Sensor */
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list