NACK[J]/Cmnt: [PATCH 0/1][SRU][J/OEM-5.14] UBUNTU: SAUCE: Revert drm/amd/pm: enable ASPM by default

[Stefan Bader]

On 28.03.22 15:13, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1966680
> 
> [Impact]
> With WX3200 and 20.04d kernel the unit freezes on resume
> 
> [Fix]
> commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled ASPM
> by default but a variety of hardware configurations it turns out that this
> caused a regression.
> 
> Multiple SKUs with wx3200&rx540 gpus encounter the resume&hange issue.
> Before the real fix is landed, revert commit 0064b0ce85bb first.
> 
> [Test Case]
> 1. plug wx3200 on the adl machine and make it as a output.
> 2. suspend&resume machine
> 3. check if machine could resume successfully
> 
> [Where problems could occur]
> Low, don't make AMDGPU ASPM by default.
> 
> Koba Ko (1):
>    Revert "drm/amd/pm: enable ASPM by default"
> 
>   drivers/gpu/drm/amd/amdgpu/nv.c                         | 2 +-
>   drivers/gpu/drm/amd/amdgpu/soc15.c                      | 2 +-
>   drivers/gpu/drm/amd/amdgpu/vi.c                         | 2 +-
>   drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
> 

In order to get things clarified: this revert never has been done in Jammy since 
we were waiting for the follow-up upstream solution. This looks to be there now 
in the form of:

* [PATCH 1/3][SRU][J/OEM-5.17] drm/amd: Refactor `amdgpu_aspm` to be evaluated
   per device
* [PATCH 2/3][SRU][J/OEM-5.17] drm/amd: Use amdgpu_device_should_use_aspm on
   navi umd pstate switching
* [PATCH 3/3][SRU][J/OEM-5.17] drm/amdgpu: vi: disable ASPM on Intel Alder Lake
   based systems

So NACKing this old submission and we would go ahead with the new one.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220713/7aa09152/attachment.sig>