ACK/Cmnt: [PATCH v2 0/3][SRU][Jammy] Headset mic with Cirrus logic codec doesn't work

[Tim Gardner]

On 7/18/22 21:42, AceLan Kao wrote:
> Tim Gardner <tim.gardner at canonical.com> 於 2022年7月18日 週一 晚上11:18寫道：
>>
>> On 7/18/22 03:04, AceLan Kao wrote:
>>> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1972815
>>>
>>> [Impact]
>>> Headset mic doesn't be selected automatically after headset is plugged in.
>>>
>>> [Fix]
>>> Cirrus provides a fix for this issue which has been merged into
>>> v5.19-rc1
>>> https://patchwork.kernel.org/project/alsa-devel/cover/20220504161236.2490532-1-sbinding@opensource.cirrus.com/
>>>
>>> ec6a8aaafbc5 ALSA: hda/cs8409: Support manual mode detection for CS42L42
>>> 9cd827381310 ALSA: hda/cs8409: Use general cs42l42 include in cs8409 hda driver
>>> 7b43e6d79562 ASoC: cs42l42: Move CS42L42 register descriptions to general include
>>>
>>> [Test]
>>> Verified on the target platform, and confirmed these patches work.
>>>
>>> [Where problems could occur]
>>> These affect the mic detection on CS8409_BULLSEYE, CS8409_WARLOCK,
>>> CS8409_WARLOCK_MLK, CS8409_WARLOCK_MLK_DUAL_MIC, CS8409_CYBORG,
>>> and CS8409_ODIN platforms. Hard to tell if it introduce any regression,
>>> will keep an eye on it.
>>>
>>> Stefan Binding (3):
>>>     ASoC: cs42l42: Move CS42L42 register descriptions to general include
>>>     ALSA: hda/cs8409: Use general cs42l42 include in cs8409 hda driver
>>>     ALSA: hda/cs8409: Support manual mode detection for CS42L42
>>>
>>>    include/sound/cs42l42.h             | 810 ++++++++++++++++++++++++++++
>>>    sound/pci/hda/patch_cs8409-tables.c | 327 ++++++-----
>>>    sound/pci/hda/patch_cs8409.c        | 275 +++++++---
>>>    sound/pci/hda/patch_cs8409.h        |   9 +-
>>>    sound/soc/codecs/cs42l42.h          | 751 +-------------------------
>>>    5 files changed, 1167 insertions(+), 1005 deletions(-)
>>>    create mode 100644 include/sound/cs42l42.h
>>>
>> Acked-by: Tim Gardner <tim.gardner at canonical.com>
>>
>> Describe your backport changes.
> The conflict parts are in the first commit for this file
> sound/soc/codecs/cs42l42.h
> It removes all defines in the file and create a new file,
> include/sound/cs42l42.h
> , to store those defines
> The conflict parts are some defines which are going to be removed do
> not exist in our old sound/soc/codecs/cs42l42.h, I just ignore them
> and remove all defines in sound/soc/codecs/cs42l42.h
> That introduces some new defines in include/sound/cs42l42.h that do
> not exist in sound/soc/codecs/cs42l42.h, and this should be no harm.
> 


What I really meant was that, in the future, I would like to see a 1 or 
2 line comment in the patch describing how the backport was performed. 
In this case you could just say something like

[AceLan - context adjustment]

I think it is particularly important to note where code changes are made 
that differ from the original patch. For example, when functions are 
renamed, prototypes are changed, structure definitions change, etc.

rtg
-- 
-----------
Tim Gardner
Canonical, Inc