ACK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: i2c-mlxbf.c: fix wrong variable name

Tim Gardner tim.gardner at canonical.com
Wed Jul 20 15:09:02 UTC 2022


On 7/20/22 07:34, Asmaa Mnebhi wrote:
> Buglink: https://bugs.launchpad.net/bugs/1982357
> 
> SRU Justification:
> 
> [Impact]
> 
> We are using the wrong variable name priv->smbus->io instead of priv->mst_cause->io. This could result in unexpected i2c behavior.
> 
> [Fix]
> 
> * replace priv->smbus->io with priv->mst_cause->io
> 
> [Test Case]
> 
> * Make sure the i2c-mlxbf.c driver is loaded and /dev/i2c-1 is created
> * check that ipmitool from the BF->BMC and from the BMC->BF work (this only applies on boards with a BMC of course)
> 
> [Regression Potential]
> 
> Any of the test cases above could be impacted due to these changes.
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list