ACK/Cmnt: [SRU][F:linux-bluefield][PATCH v4 0/1] UBUNTU: SAUCE: i2c-mlxbf.c: support lock mechanism

[Tim Gardner]

On 7/21/22 08:05, Asmaa Mnebhi wrote:
> Buglink: https://bugs.launchpad.net/bugs/1981105
> 
> SRU Justification:
> 
> [Impact]
> 
> Support the I2C lock mechanism, otherwise there could be unexpected behavior when an i2c bus is accessed by several entities like the linux driver, ATF driver and UEFI driver. Make sure to pick up the ATF/UEFI image to accompany this change
> because at boot time ATF will ensure that the lock is released.
> 
> [Fix]
> 
> * Support lock and unlock
> * replace ioremap_nocache with ioremap
> 
> [Test Case]
> 
> * Make sure the i2c-mlxbf.c driver is loaded and /dev/i2c-1 is created
> * check that ipmitool from the BF->BMC and from the BMC->BF work (this only applies on boards with a BMC of course)
> 
> [Regression Potential]
> 
> Any of the test cases above could be impacted due to these changes.
> Make sure you load the latest ATF/UEFI image to accompany this change.
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

Now that you have 4 call sites for mlx_smbus_master_unlock() you could 
make the code cleaner by having a common exit at the end of the function 
mlx_smbus_start_transaction(), but that's a change for another patch.

rtg
-- 
-----------
Tim Gardner
Canonical, Inc