ACK/Cmnt: NAK: [Pull Request] [J/linux-nvidia] NVMe/MVMEeOF: Patch NVMe/NVMeOF driver to support GDS

[Stefan Bader]

On 22.07.22 16:33, Tim Gardner wrote:
> On 7/22/22 08:00, Stefan Bader wrote:
>> On 22.07.22 15:05, Tim Gardner wrote:
>>> On 7/21/22 18:22, Brad Figg wrote:
>>>> The following changes since commit f55ad35dc7637ef61904ae01c8066cd51d45c481:
>>>>
>>>>    UBUNTU: Ubuntu-nvidia-5.15.0-1003.3 (2022-07-09 13:45:33 -0700)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>    https://github.com/NVIDIA-BaseOS-6/linux-nvidia.git 
>>>> fcfe85048ab7e3afead7216234ebc59fd999b3b8
>>>>
>>>> for you to fetch changes up to fcfe85048ab7e3afead7216234ebc59fd999b3b8:
>>>>
>>>>    NVMe/MVMEeOF: Patch NVMe/NVMeOF driver to support GDS (2022-07-21 
>>>> 16:08:08 -0700)
>>>>
>>>> ----------------------------------------------------------------
>>>> Sourab Gupta (1):
>>>>        NVMe/MVMEeOF: Patch NVMe/NVMeOF driver to support GDS
>>>>
>>>>   drivers/nvme/host/Makefile    |   4 +++-
>>>>   drivers/nvme/host/nvfs-dma.c  |  52 
>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>   drivers/nvme/host/nvfs-dma.h  | 122 
>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 
>>>>
>>>>   drivers/nvme/host/nvfs-rdma.c |  52 
>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>   drivers/nvme/host/nvfs-rdma.h | 130 
>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 
>>>>
>>>>   drivers/nvme/host/nvfs.h      | 113 
>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 
>>>>
>>>>   drivers/nvme/host/pci.c       |  17 +++++++++++++++++
>>>>   drivers/nvme/host/rdma.c      |  19 +++++++++++++++++++
>>>>   8 files changed, 508 insertions(+), 1 deletion(-)
>>>>   create mode 100644 drivers/nvme/host/nvfs-dma.c
>>>>   create mode 100644 drivers/nvme/host/nvfs-dma.h
>>>>   create mode 100644 drivers/nvme/host/nvfs-rdma.c
>>>>   create mode 100644 drivers/nvme/host/nvfs-rdma.h
>>>>   create mode 100644 drivers/nvme/host/nvfs.h
>>>>
>>>>
>>>
>>> This pull request appears to be a subset of [1] which already included commit 
>>> fcfe85048ab7e3afead7216234ebc59fd999b3b8 ("NVMe/MVMEeOF: Patch NVMe/NVMeOF 
>>> driver to support GDS").
>>
>> I believe you mis-read the pull request format. The "since commit" refers to 
>> the commit BEFORE the one taken with cherry-pick or format-patch. Those two 
>> pulls are separate but on top of each other.
>>
>> -Stefan
>>
>>>
>>> rtg
>>>
>>> [1] https://lists.ubuntu.com/archives/kernel-team/2022-July/132088.html
>>
> Acked-by: Tim Gardner <tim.gardner at canonical.com>
> 
> Well, in that case I've already reviewed both patches in the first pull request.
> 
I suppose Brad could have sent single patches but he is fighting outlook 
nowadays... I hear that is even worse than Thunderbird...

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220722/5f79b517/attachment-0001.sig>