[SRU][F:linux-bluefield][PATCH 0/1] UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: mlxbf_gige: add interrupt counts to "ethtool -S""

Tim Gardner tim.gardner at canonical.com
Fri May 20 12:28:15 UTC 2022


Why revert this now ? A quick look upstream shows that interrupt 
statistics do not appear to be kept. Won't this break user space ?

rtg

On 5/19/22 15:51, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/1974241
> 
> SRU Justification:
> 
> [Impact]
> 
> There is a mlxbf_gige driver commit (ed0dd97e64a5) which pertains to
> "UBUNTU: SAUCE: mlxbf_gige: add interrupt counts to "ethtool -S".
> This logic is modified in upstream Linux, so this SAUCE commit will
> need to be reverted.
> 
> [Fix]
> 
> The fix is to revert this driver commit.
> 
> [Test Case]
> 
> With this commit reverted the driver should function as before
> (e.g. probe succeeds, oob_net0 link up, etc) EXCEPT that the
> output of "ethtool -S" will no longer show the interrupt counts.
> 
> [Regression Potential]
> 
> The amount of driver logic being reverted is quite small, so
> no potential for creating a regression.
> 
> David Thompson (1):
>    UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: mlxbf_gige: add interrupt counts
>      to "ethtool -S""
> 
>   .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c       | 14 +++++---------
>   1 file changed, 5 insertions(+), 9 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list