ACK: [SRU][F:linux-bluefield][PATCH 0/1] UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read

Tim Gardner tim.gardner at canonical.com
Fri Sep 16 15:35:50 UTC 2022


On 9/13/22 11:28, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/1989495
> 
> SRU Justification:
> 
> [Impact]
> The BlueField-2 GIGE logic accesses the MDIO device via reads/writes
> to a gateway (GW) register. The MDIO GW lock is set after read. Make
> sure to always clear to indicate that the GW register is not being used.
> If the lock is mistakenly interpreted as ACTIVE, then subsequent MDIO
> accesses will be blocked and PHY device will be inaccessible.
> 
> [Fix]
> For each MDIO read and write transaction, the last step should
> be to clear the MDIO GW lock.
> 
> [Test Case]
> Boot the BlueField-2 platform
> Bring up the "oob_net0" interface via DHCP or static IP
> Ping and file transfer over "oob_net0" should work properly
> Bounce the "oob_net0" interface a few times and repeat tests
> 
> [Regression Potential]
> * Low risk for causing a regression, tested well in our lab.
> 
> [Other]
> * None
> 
> David Thompson (1):
>    UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read
> 
>   drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list