NACK: [autotest-client-tests][PATCH 0/1 v2] Add ubuntu_xilinx regression tests

[Portia Stephens]

On Wed, Sep 21, 2022 at 11:36 PM Tim Gardner <tim.gardner at canonical.com> wrote:
>
> On 9/20/22 17:19, Portia Stephens wrote:
> > On Fri, Sep 16, 2022 at 9:19 PM Portia Stephens
> > <portia.stephens at canonical.com> wrote:
> >>
> >> Add regression tests for Xilinx hardware. These tests are expected to be
> >> run on Xilinx hardware, specifically kv206 and zcu boards. These scripts
> >> were copied and modified from the raspberry_pi regression tests.
> >>
> >> Portia Stephens (1):
> >>    UBUNTU: SAUCE: ubuntu_xilinx: Initial commit of Xilinx test suite
> >>
> >>   ubuntu_xilinx/control          |  17 +++
> >>   ubuntu_xilinx/lib/run-test     | 202 +++++++++++++++++++++++++++++++++
> >>   ubuntu_xilinx/tests/splat      |  25 ++++
> >>   ubuntu_xilinx/ubuntu_xilinx.py |  14 +++
> >>   4 files changed, 258 insertions(+)
> >>   create mode 100644 ubuntu_xilinx/control
> >>   create mode 100755 ubuntu_xilinx/lib/run-test
> >>   create mode 100755 ubuntu_xilinx/tests/splat
> >>   create mode 100644 ubuntu_xilinx/ubuntu_xilinx.py
> >>
> >> --
> >> 2.34.1
> >>
> >
>
> Is there a reason for your NACK ?

Sam pointed out that the first test I enabled which checks for kernel
warnings is already being done by ubuntu_boot and ubuntu_boot is
already run on the xilinx kernels. I will send a v3 with a different
test.

>
> --
> -----------
> Tim Gardner
> Canonical, Inc