[PATCH 6/9] UBUNTU: [Packaging] convert to direct ancillaries

Andy Whitcroft apw at canonical.com
Fri Sep 23 13:45:03 UTC 2022


On Fri, Sep 23, 2022 at 2:39 PM Stefan Bader <stefan.bader at canonical.com> wrote:
> > +validate_unique()
> > +{
> > +     [ "$#" = "2" ]
>
> Maybe cleverly short but hard to read...
>
> > +     local duplicates=$(echo $2 | tr " " "\n" | sort | uniq -d)
> > +     if [ "$duplicates" ]; then
> > +             echo "EE: duplicate values in $1" 1>&2
> > +             exit 1
>
> Both tests _are_ supposed to abort any execution, right? First exit would be silent.
>
> > +     fi
> > +}

Yeah all valid complaints.  None of this code is new however, you are
only seeing it because git has made a poor choice when this file was
renamed.  Basically I rename two files, and replace one of the
originals, doing that makes git do the wong things for this file.  It
is most annoying.

-apw



More information about the kernel-team mailing list