ACK/Cmnt: [RFC] linux-restricted-modules support for open variants (and direct ancillaries)

[Stefan Bader]

On 14.09.22 15:54, Andy Whitcroft wrote:
> Nvidia are starting to produce unencumbered binaries which we are
> permitted to pre-link for shipping.  This patch series represents the
> necessary changes to support the new -open variants.  It also contains
> changes needed to convert LRM to direct-ancillary form; a simpler
> internal representation which is more extensible to other uses, and much
> clearer to review.
> 
> Following this email are three sets of patches.  The first four
> represent various simple fixes found when converting the LRM packages to
> direct-ancillary form:
> 
> 0001-UBUNTU-Packaging-fix-our-dh_clean-override.patch
> 0002-UBUNTU-Packaging-clamp-versions-to-dkms-versions-at-.patch
> 0003-UBUNTU-Packaging-lrg-does-not-use-fix-filenames.patch
> 0004-UBUNTU-Packaging-fix-rule-generation-line-continuati.patch
> 
> The next two represent the conversion to direct-ancillary form. The
> first of these parameterises the ancillaries using various bits of data
> from the primary package.  The second is the mechanical conversion
> (which is ultimatly all renames with very minor changes though git is
> unable to identify one of the renames):
> 
> 0005-UBUNTU-Packaging-parameterise-ancillary-packages.patch
> 0006-UBUNTU-Packaging-convert-to-direct-ancillaries.patch
> 
> The last three add variant support to LRM.  This allows us to consume
> two different nvidia-graphics-drivers from the same main package
> version, and allows us build and publish the .kos directly:
> 
> 0007-UBUNTU-Packaging-add-variant-tag-to-allow-us-to-sele.patch
> 0008-UBUNTU-Packaging-handle-the-open-variant.patch
> 0009-UBUNTU-lrm-version-6.0.patch
> 
> Proposing to apply this to kinetic initially and once settlet, to
> programatically apply this to all existant LRM package as listed in
> kernel-series as LRMv6.
> 
> -apw
> 

My issues are more or less readability ones. Which might make it hard to 
maintain. Not sure it is any better if I looked at it in the final script form 
and not as diff. Within the mail reader without syntax highlighting and small 
font its double hard. A lot of the new code I likely need to see in action.
But one has to start somewhere ... so

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220923/20101770/attachment.sig>