APPLIED [OEM-5.17] Re: [SRU] [J/K/OEM-5.19] [PATCH 0/3] Fix resume on AMD platforms when TBT monitor is plugged

[Kai-Heng Feng]

On Wed, Sep 28, 2022 at 4:37 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 27.09.22 10:12, Timo Aaltonen wrote:
> > Kai-Heng Feng kirjoitti 27.9.2022 klo 9.59:
> >> BugLink: https://bugs.launchpad.net/bugs/1990920
> >>
> >> [Impact]
> >> When TBT monitor is connected to AMD platform, system resume will hit
> >> stack corruption or BUG_ON() macro.
> >>
> >> [Fix]
> >> Revert the offending commit and handle MST properly.
> >>
> >> [Test]
> >> The system can resume normally and no more kernel splat.
> >>
> >> [Where problems could occur]
> >> The new logic is restriced to MST hub, so normal DP/HDMI usage should be
> >> unaffected.
> >>
> >> Kai-Heng Feng (1):
> >>    Revert "drm/amd/display: Add helper for blanking all dp displays"
>
> This was part of enabling DP tunneling. I do not see it reverted for upstream.
> If the backport was causing regressions, should it not have been handled in
> Jammy at least as a separate bug? Will this not have impact on DP tunneling?

Adding the helper is to reduce open-coding, any functional change is
not intended. So the upstream commit
c494e57992f9b85e72fac3003358387249b359b6 ("Revert "drm/amd/display:
Add helper for blanking all dp displays"") reverted it.

The correct helper was later added as
ebd1e719695824ca2b9225094a669fef35620676 ("drm/amd/display: Add helper
for blanking all dp displays").

Kai-Heng

>
> -S
>
> >>
> >> Wayne Lin (2):
> >>    drm/amd/display: Detect dpcd_rev when hotplug mst monitor
> >>    drm/amd/display: Release remote dc_sink under mst scenario
> >>
> >>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  5 +-
> >>   .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 18 +----
> >>   .../display/amdgpu_dm/amdgpu_dm_mst_types.c   | 72 +++++++++++++++++--
> >>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 45 ------------
> >>   drivers/gpu/drm/amd/display/dc/dc_link.h      |  1 -
> >>   .../display/dc/dce110/dce110_hw_sequencer.c   | 13 +++-
> >>   .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 41 ++++++++++-
> >>   .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    | 39 +++++++++-
> >>   .../drm/amd/display/dc/dcn31/dcn31_hwseq.c    | 37 +++++++++-
> >>   9 files changed, 192 insertions(+), 79 deletions(-)
> >>
> >
> > applied to oem-5.17, thanks
> >
> > (careful with the topic :)
> >
>