[SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read"

Tim Gardner tim.gardner at canonical.com
Thu Sep 29 12:34:23 UTC 2022


On 9/28/22 14:37, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/1991151
> 
> SRU Justification:
> 
> [Impact]
> 
> The Jammy repo contains the following SAUCE patch:
> UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read
> 
> This patch is now in mainline Linux kernel, so the SAUCE patch
> can be reverted and replaced with the upstream commit SHA.
> 
> [Fix]
> 
> The fix requires two parts, the first of which is addressed by
> this bug. A second bug will be created to add the upstream
> commit to the repo. The fix to this bug is a revert of the SAUCE patch
> 8d2dbbd437a1 UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read
> 
> [Test Case]
> 
> Boot platform and bring up "oob_net0" interface properly
> Test that network traffic works properly
> 
> [Regression Potential]
> 
> Low, as this logic is well tested.
> 
> [Other]
> 
> Will add a note to this bug with the second bug's number,
> after the second bug is created. The second bug is for
> adding the upstream commit to the Jammy repo.
> 
> David Thompson (1):
>    UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway
>      lock after read"
> 
>   drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 6 ------
>   1 file changed, 6 deletions(-)
> 

Why create a second LP report just to apply an upstream commit ? It 
makes more sense to me to have the revert and the upstream commit 
applied within the same report. Unless the upstream commit is part of a 
larger series, in which case the revert should be prepended to that series.

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list