[SRU][F][J][K][Unstable][PATCH 0/2] Fix keyboard inoperative on Asus Vivobook S5402ZA

[Stefan Bader]

On 29.09.22 20:08, Tim Gardner wrote:
> On 9/29/22 11:58, Kellen Renshaw wrote:
>> Hello Tim,
>>
>> Certainly! Apologies for getting ahead of myself.
>>
>> Is being in linux-next a prerequisite for patches to be accepted?
>>
> 
> Since Focal and Jammy are both LTS kernels, you have to have a pretty good 
> reason to apply patches from untested provenance sources. Also, it'll keep 
> Stefan off your case :)

Hey, I am much less biting nowadays. :-P But seriously, yeah for actually any 
SRU update I/we just started to delay until things are at least in linux-next. 
That usually is a good indication that things are settled. Quite often there 
have been subtle changes between appearing in subsystem trees and next. If we 
have need to really pick up things before we should mark those as SAUCE and 
check back to replace that with upstream patches.

-Stefan

> 
> If they are headed upstream, then you also don't really need to specify 
> 'Unstable' since that kernel should get them organically.
> 
> rtg
> 
>>
>> On Thu, Sep 29, 2022 at 5:40 AM Tim Gardner <tim.gardner at canonical.com> wrote:
>>>
>>> On 9/28/22 14:44, Kellen Renshaw wrote:
>>>> Buglink: https://bugs.launchpad.net/bugs/1990425
>>>>
>>>> SRU Justification:
>>>>
>>>> [Impact]
>>>>
>>>> * The builtin keyboard on the Asus S5402ZA doesn't work with any currently 
>>>> released kernel.
>>>>
>>>> [Fix]
>>>>
>>>> * 6e5cbe7c4b41824e500acbb42411da692d1435f1 ACPI: resource: Add ASUS model 
>>>> S5402ZA to quirks
>>>>
>>>>     * 
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=6e5cbe7c4b41824e500acbb42411da692d1435f1 
>>>>
>>>>
>>>> * e12dee3736731e24b1e7367f87d66ac0fcd73ce7 ACPI: resource: Skip IRQ override 
>>>> on Asus Vivobook K3402ZA/K3502ZA
>>>>
>>>>     * 
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=e12dee3736731e24b1e7367f87d66ac0fcd73ce7 
>>>>
>>>>
>>>> * These are from the upstream linux-pm tree, accepted for Linux 6.1, 
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/
>>>>
>>>> [Test Plan]
>>>>
>>>> * Install Ubuntu on an Asus S5402ZA and verify that the internal keyboard 
>>>> doesn't work.
>>>>
>>>> * Install kernel with the above patches.
>>>>
>>>> * Boot into patched kernel and verify that the internal keyboard now works.
>>>>
>>>> [Where problems could occur]
>>>>
>>>> * These patches could cause the keyboard to not work if there are 
>>>> differences in hardware/firmware revisions.
>>>>
>>>> [Other Info]
>>>>
>>>> * The patch requires e12dee3736731e24b1e7367f87d66ac0fcd73ce7 for the 
>>>> addition of the quirk mechanism.
>>>>
>>>> * e12dee373673 includes quirks for the Asus K3402ZA/K3502ZA models. These 
>>>> were tested and accepted by upstream.
>>>>     See bug below.
>>>>
>>>> * The patchset has been tested on an Asus S5402ZA with a test kernel and 
>>>> found to work.
>>>>
>>>> * Upstream bug tracker: https://bugzilla.kernel.org/show_bug.cgi?id=216158
>>>>
>>>>
>>>>
>>>
>>> Can this wait until the patches are at least in linux-next ? Once in
>>> linux-next they are unlikely to change.
>>>
>>> -- 
>>> -----------
>>> Tim Gardner
>>> Canonical, Inc
>>
>>
>>
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220930/41423111/attachment.sig>