APPLIED[K/J/F]: [F/J/K][OEM-5.17/OEM-6.0][SRU][PATCH 0/1] selftest: fib_tests: Always cleanup before exit
Stefan Bader
stefan.bader at canonical.com
Thu Apr 13 09:09:15 UTC 2023
On 12.04.23 07:06, Po-Hsu Lin wrote:
> [Impact]
> Copied from the commit message:
> Usage of `set -e` before executing a command causes immediate exit
> on failure, without cleanup up the resources allocated at setup.
> This can affect the next tests that use the same resources,
> leading to a chain of failures.
>
> A simple fix is to always call cleanup function when the script exists.
> This approach is already used by other existing tests.
>
> [Fix]
> * b60417a9f2 selftest: fib_tests: Always cleanup before exit
>
> This patch can be cherry-picked into affected kernels.
>
> [Test]
> Run the patched fib_tests.sh on KVM kernels, which is expected to fail
> due to bug 2007458.
> Check with `ip netns`, the ns1 added during setup() should be removed.
>
> [Where problems could occur]
> Test robustness improvement, this should not break things.
>
> Roxana Nicolescu (1):
> selftest: fib_tests: Always cleanup before exit
>
> tools/testing/selftests/net/fib_tests.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied to kinetic,jammy,focal:linux/master-next. Thanks.
-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230413/28114895/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230413/28114895/attachment-0001.sig>
More information about the kernel-team
mailing list