NACK/Cmnt: [PATCH 0/1][SRU][L/K/J/OEM-6.1] Dell: Enable speaker mute hotkey LED indicator

[Tim Gardner]

On 4/13/23 8:54 PM, Koba Ko wrote:
> On Thu, Apr 13, 2023 at 8:40 PM Tim Gardner <tim.gardner at canonical.com> wrote:
>>
>> On 4/13/23 2:03 AM, Koba Ko wrote:
>>> On Thu, Apr 13, 2023 at 3:54 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>>>>
>>>> On 13.04.23 04:22, Koba Ko wrote:
>>>>> BugLink: https://bugs.launchpad.net/bugs/2015972
>>>>>
>>>>> [Feature Description]
>>>>> When users press the speaker mute hotkey and the speaker is muted,
>>>>> the speaker mute LED indicator will light up.
>>>>> When the speaker is not muted,
>>>>> the speaker mute LED indicator will light out.
>>>>>
>>>>> [Test Case]
>>>>> 1. run G16 with target kernel.
>>>>> 2. press the mute hotkey
>>>>> 3. check if speaker mute led can be switched.
>>>>>
>>>>> [Where problems could occur]
>>>>> Low, just register a speaker mute led control for dell-laptop.
>>>>>
>>>>> [MISC]
>>>>> Passed compilation on J/K/L cbd.
>>>>>
>>>>> Koba Ko (1):
>>>>>      [SRU][L/K/J/OEM-6.1] platform/x86: dell-laptop: Register ctl-led for
>>>>>        speaker-mute
>>>>>
>>>>>     drivers/platform/x86/dell/dell-laptop.c | 42 +++++++++++++++++++++++++
>>>>>     drivers/platform/x86/dell/dell-smbios.h |  2 ++
>>>>>     2 files changed, 44 insertions(+)
>>>>>
>>>>
>>>> Rejected for the following reasons:
>>>> - Patch is not upstream (in linux-next) but uses a cherry pick
>>>>      line as if it were.
>>>>
>>>> -Stefan
>>>
>>> it has been merged into linux-next,
>>> ~~~
>>>    $ git branch --contains 3ed0b880b71489d59f89b0bc1323ad34a136cca0
>>>     l_vnlaNxt
>>> ~~~
>>> Ref. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3ed0b880b71489d59f89b0bc1323ad34a136cca0
>>>
>>
>> Then the cherry- picked line should read:
>>
>> (cherry picked from commit 3ed0b880b71489d59f89b0bc1323ad34a136cca0
>> linux-next)
> 
> Thanks.
> I didn't mark it as cherry-pick from linux/linux-next so I'm confused.
> 

I commented on this thread before I saw v2 (which is correct wrt 
linux-next in the cherry picked line).

-- 
-----------
Tim Gardner
Canonical, Inc