[SRU][Kinetic][PATCH 0/3] Fix udpgro_frglist.sh kernel selftest

[Stefan Bader]

On 10.02.23 10:38, Andrei Gherzan wrote:
> Hi Stefan,
> 
> Thanks for the review.
> 
> On Fri, 10 Feb 2023, 08:44 Stefan Bader, <stefan.bader at canonical.com 
> <mailto:stefan.bader at canonical.com>> wrote:
> 
>     Patch #2 is missing the BugLink, which of the 2 should be used when
>     applying? Generally, it would be better to either duplicate bug reports
>     or submit individually. One thing to fix per submission is simpler to
>     manage.
> 
> 
> I avoided a bug link on that patch because it is a fix of a fix. It is a 
> fix of the CC support for net bpf progs. Now that I think about it, I 
> reckon we should go ahead and use the same BugLink with the CC support - 
> https://bugs.launchpad.net/bugs/1996536 
> <https://bugs.launchpad.net/bugs/1996536>. I'm happy to resubmit a V2 
> with this change.

Since it is clarified now, there is no need to re-submit. We just fix it 
up when applying. We always have to use some reference since that is 
what puts things together in the changelog. And we also need it as SRU 
rules say that no change should be made without a bug report.

> 
> I understand and support the maintenance advantage of talking one bug 
> per submission but in this case there was a tight relationship between 
> these two entries. One failed because of a dependency disabled by 
> another. So being able to fix and test the former required work on the 
> latter. I hoped that this was an acceptable balance of submission and 
> maintenance/review overhead. Similarly though, I'm happy to split and 
> resubmit if deemed otherwise.

Again it is ok as it now. And in this case there is good reason to have 
done so. Just for the general case it is hard to double check on the bug 
references.

> 
> agh

- Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230213/710a31ff/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230213/710a31ff/attachment-0001.sig>