NAK: [SRU][F:linux-bluefield][PATCH v1 0/2] Add HW offloaded CT stats

Tim Gardner tim.gardner at canonical.com
Thu Feb 23 18:45:31 UTC 2023


On 2/23/23 11:11 AM, William Tu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2008136
> 
> When CT HW offload is enabled, the CT stats does not show the stats of
> the offloaded flow. Ex: using 'cat /proc/net/nf_conntrack', or
> 'conntrack -L' shows only the software CT stats, not the offloaded CT
> flow stats.
> 
> The series cherry-pick two patches below
> ef803b3cf96a ("netfilter: flowtable: add counter support in HW offload")
> 9312eabab4a6 ("netfilter: conntrack: add nf_ct_acct_add()")
> I need to change a little due to cherry-pick conflict with
> 24384e28586c ("netfilter: flowtable: Set offload timeouts according to
> proto values")
> 
> wenxu (2):
>    netfilter: conntrack: add nf_ct_acct_add()
>    netfilter: flowtable: add counter support in HW offload
> 
>   include/net/netfilter/nf_conntrack_acct.h | 11 ++++++++++-
>   net/netfilter/nf_conntrack_core.c         |  7 ++++---
>   net/netfilter/nf_flow_table_offload.c     | 12 ++++++++++++
>   3 files changed, 26 insertions(+), 4 deletions(-)
> 

Patch 2 has a comment below your Signed-off-by that implies the patch is 
a backport instead of a cherry pick. Furthermore, the comment 'fix 
flow_offload_get_timeout' makes no sense to me.

-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list