ACK/Cmnt: [PATCH 0/5][SRU][M/L] Fix AMDGPU: the screen freeze with W7500

Stefan Bader stefan.bader at canonical.com
Wed Jul 19 08:02:19 UTC 2023


On 18.07.23 12:50, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/2027957
> 
> [impact]
> While booting into OOBE, the screen freeze [AMD W7500 only]
> 
> [fix]
> AMDGPU would allocate pcie gen/lane dynamically after ASPM is enabled.
> Intel CPU may not support the dynamic lane/speed switching.
> 
> Solution is,
> - Detect Intel x86 systems that don't support dynamic switching
> - Override the input caps to maximum supported for that system
> - Force all PCIe levels to use the same settings, rather than try to configure each level differently.
> 
> [test cases]
> 1. boot with w7500
> 2. the screen doesn't freeze and can't find the error message in dmesg.
> "amdgpu: [drm] *ERROR* [CRTC:72:crtc-0] flip_done timed out"
> 
> [where the issue could happen]
> low, this could lead issue when setting higher speeds than supported.
> 
> [Misc]
> 1. jammy, amdgpu isn't loaded on this platform with 5.15-73-generic.
> 2. kinetic, amdgpu failed to probe the vga controller with 5.19-46-generic.
> 3. Passed cbd build against Mantic&Lunar.
> 4. For Lunar, need modification for function sienna_cichlid_update_pcie_parameters,
>     so provide another patch for e701156ccc6c) drm/amd: Align SMU11 SMU_MSG_OverridePcieParameters.
> 

Patches at least now are in linux-next:

dcb489bae65d92cfd26da22c7a0d6665b06ecc63
   drm/amd/pm: share the code around SMU13 pcie parameters update
31c7a3b378a136adc63296a2ff17645896fcf303
   drm/amd/pm: conditionally disable pcie lane/speed switching for SMU13
188623076d0f1a500583d392b6187056bf7cc71a
   drm/amd: Move helper for dynamic speed switch check out of smu13
e701156ccc6c7a5f104a968dda74cd6434178712
   drm/amd: Align SMU11 SMU_MSG_OverridePcieParameters implementation with
   SMU13

As far as I can see those seem to be the same as in drmtip. So this is 
acceptable as SRU and we should check when applying (maybe by then this 
is all upstream).

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230719/d31a86e2/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230719/d31a86e2/attachment-0001.sig>


More information about the kernel-team mailing list