NACK/Cmnt: [focal][PATCH] builddeb: allow selection of .deb compressor

[Masahiro Yamada]

On Mon, Jul 24, 2023 at 6:57 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 24.07.23 10:23, Masahiro Yamada wrote:
> > From: Michał Mirosław <mirq-linux at rere.qmqm.pl>
> >
> > [ Upstream commit 1a7f0a34ea7d05d1ffcd32c9b1b4e07ac0687538 ]
> >
> > Select deb compression using KDEB_COMPRESS make variable. This allows to
> > use gzip compression for local or test builds, and that's way faster
> > than now-default xz compression.
> >
> > Signed-off-by: Michał Mirosław <mirq-linux at rere.qmqm.pl>
> > Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>
> > Signed-off-by: Masahiro Yamada <masahiro.yamada at canonical.com>
> > ---
> >
> > This is not a bug-fix, but this is useful to speed-up 'make bindeb-pkg'.
> >
> >
> >   scripts/package/builddeb | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> > index c4c580f547ef..b68aaeece7c9 100755
> > --- a/scripts/package/builddeb
> > +++ b/scripts/package/builddeb
> > @@ -43,7 +43,7 @@ create_package() {
> >
> >       # Create the package
> >       dpkg-gencontrol -p$pname -P"$pdir"
> > -     dpkg --build "$pdir" ..
> > +     dpkg-deb ${KDEB_COMPRESS:+-Z$KDEB_COMPRESS} --build "$pdir" ..
> >   }
> >
> >   version=$KERNELRELEASE
>
> Rejected for the following reasons:
> - not following SRU policy
> (https://wiki.ubuntu.com/KernelTeam/KernelUpdates)

Could you tell me which policy rejects this patch?

Is it a style problem, or is this patch itself unacceptable?



> - also not sure Focal was already using xz

I am afraid you are misunderstanding.

The build host does not need to be focal
(or does not need to be even Ubuntu).

This is useful when you build a debian package
in a mainline way.

See my replies to Dimitry.




>
> -Stefan