NACK/Cmnt: [SRU][Jammy][PATCH 0/1] UBUNTU: [Config] arm64: Enable PCI_MESON module

[Stefan Bader]

On 24.03.23 12:44, Isaac True wrote:
> Thanks Stefan, still getting used to formatting the git emails properly.
> 
> Do you want me to resubmit it all?
> 
> On Fri, 24 Mar 2023 at 12:31, Stefan Bader <stefan.bader at canonical.com> wrote:
>>
>> On 24.03.23 11:28, Isaac True wrote:
>>
>> The cover email should rather be "[SRU J/K/L]... " since then its clear
>> what will follow. You could prepare the whole batch by using
>> --start-number on the other kernels format-patch. Then everything can be
>> sent in one go.
>>
>> -Stefan
>>
>>> BugLink: https://bugs.launchpad.net/bugs/2007745
>>>
>>> [ Impact ]
>>>
>>> The PCI driver for the amlogic-based Meson platforms (CONFIG_PCI_MESON)
>>> is not enabled as a module in the kernel configuration.
>>>
>>> [ Test Plan ]
>>>
>>> Check if pci_meson.ko is compiled and present in the linux-modules
>>> package.
>>>
>>> [ Where problems could occur ]
>>>
>>> This driver does not enable any dependencies that the kernel does not
>>> already have enabled, and it is a stable upstream driver. There
>>> shouldn't be any issues that arise from enabling this driver.
>>>
>>> [ Other Info ]
>>>
>>> This driver is important for systems like the ODROID HC4, which uses a
>>> PCIE-SATA bridge to provide a storage interface. This system is fully
>>> supported by the kernel (including a device tree), except for the fact
>>> that this PCI driver is disabled.
>>>
>>> Isaac True (1):
>>>     UBUNTU: [Config] arm64: Enable PCI_MESON module
>>>
>>>    debian.master/config/amd64/config.common.amd64     | 1 +
>>>    debian.master/config/annotations                   | 2 +-
>>>    debian.master/config/arm64/config.common.arm64     | 1 +
>>>    debian.master/config/armhf/config.common.armhf     | 1 +
>>>    debian.master/config/config.common.ubuntu          | 1 -
>>>    debian.master/config/ppc64el/config.common.ppc64el | 1 +
>>>    debian.master/config/s390x/config.common.s390x     | 1 +
>>>    7 files changed, 6 insertions(+), 2 deletions(-)
>>>
>>
>>

Yeah as explained in other conversations it is better to have the top 
level mention all affected targets.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230324/bdde3048/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230324/bdde3048/attachment-0001.sig>