APPLIED [OEM-5.17/OEM-6.0] Re: [F/J/K][OEM-5.17/OEM-6.0][SRU][PATCH 0/1] selftest: fib_tests: Always cleanup before exit

Timo Aaltonen tjaalton at ubuntu.com
Tue May 30 09:24:54 UTC 2023


Po-Hsu Lin kirjoitti 12.4.2023 klo 8.06:
> [Impact]
> Copied from the commit message:
> Usage of `set -e` before executing a command causes immediate exit
> on failure, without cleanup up the resources allocated at setup.
> This can affect the next tests that use the same resources,
> leading to a chain of failures.
> 
> A simple fix is to always call cleanup function when the script exists.
> This approach is already used by other existing tests.
> 
> [Fix]
> * b60417a9f2 selftest: fib_tests: Always cleanup before exit
> 
> This patch can be cherry-picked into affected kernels.
> 
> [Test]
> Run the patched fib_tests.sh on KVM kernels, which is expected to fail
> due to bug 2007458.
> Check with `ip netns`, the ns1 added during setup() should be removed.
> 
> [Where problems could occur]
> Test robustness improvement, this should not break things.
> 
> Roxana Nicolescu (1):
>    selftest: fib_tests: Always cleanup before exit
> 
>   tools/testing/selftests/net/fib_tests.sh | 2 ++
>   1 file changed, 2 insertions(+)
> 

Applied to oem-5.17 & 6.0, though the 6.0 missed the current cycle.

-- 
t




More information about the kernel-team mailing list