ACK Re: [SRU Lunar:<all>] Include cifs.ko in linux-modules package

[Timo Aaltonen]

Roxana Nicolescu kirjoitti 2.11.2023 klo 14.52:
> BugLink: https://bugs.launchpad.net/bugs/2042546
> 
> SRU Justification:
> 
> [Impact]
> 
> Commit: "smb: move client and server files to common directory fs/smb"
> introduced in 2023.09.04 moved the fs/cifs directory to fs/sb/client.
> The inclusion list for linux-modules was not updated, it still contains
> the old path. This means that the cifs.ko module cannot be loaded if only
> linux-modules package is installed, now being part of linux-modules-extra.
> For lunar:main this is not a problem because linux-modules-extra is always
> installed, but for derivatives like aws, azure etc, this module cannot be
> loaded without explicitly installing linux-modules-extra.
> 
> [How to reproduce it]:
> 1. Install the latest azure kernel 6.2.0-1016.16
> 2. Load cifs module
> $ modprobe cifs
> modprobe: FATAL: Module cifs not found in directory /lib/modules/6.2.0-1016-azure
> If modules-extra is installed, this works.
> 
> [Fix]
> 
> Replace fs/cifs/* with fs/smb/client/*
> in debian.<derivative>/control.d/<derivative>.inclusiojn-list
> Since this is straightforward fix, it is going to be released in
> the s2023.10.02 cycle for derivatives.
> 
> [Test Plan]
> 
> 1. Apply the fix to one of the derivative (azure), build a new kernel and
> install it
> 2. Load cifs module
> $ modprobe cifs
> It should work without installing modules-extra.
> 
> [Regression potential]
> 
> Very low, it's a straightforward fix.
> 
> [Other Info]
> Sending a patch for every derivative takes time and each derivative will
> be fixed once this proposal is acked.
> There is also the possibility to do it via cranky fix, but owners may omit
> it during security updates and it's hard to enforce it. Plus, it is a
> one-time change.
> 
> 

Acked-by: Timo Aaltonen <timo.aaltonen at canonical.com>

-- 
t