NACK: [SRU][focal:linux-gcp-5.15][PULL v2] TCPDirect patches

[Tim Gardner]

On 9/22/23 9:13 AM, Thadeu Lima de Souza Cascardo wrote:
> On Fri, Sep 22, 2023 at 09:00:52AM -0600, Tim Gardner wrote:
>> On 9/22/23 6:36 AM, John Cabaj wrote:
>>> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux-gcp-5.15/+bug/2037087
>>>
>>> [Impact]
>>>
>>> * Include patches to enable TCPDirect. This is considered a v1 implementation while Google works to
>>>     upsteam a v2 implementation, hence the "UBUNTU: SAUCE: (no-up)" classification.
>>>
> [...]
>> I am confused. f/gcp-5.15 is a derived kernel. Why wouldn't you apply this
>> patch set to j/gcp ?
>> -- 
> 
> Not only that, but all later kernels must have it before you apply to 5.15
> kernels. This needs to go to unstable, then mantic, lunar, jammy, etc.
> 
> But I am very antsy about these patches as they change user interfaces and how
> TCP works.
> 
> We haven't even seen the upstream submission and reaction from upstream
> maintainers. For all I know, this could never be accepted and we will have to
> either live with these patches downstream for a long while or decide to drop
> support from userspace that is relying on this.
> 
> This requires further discussion before a new version is submitted.
> 
> Cascardo.
> 

I agree with Thadeu. We can't be compromising the upgrade path. Its got 
to be top down.

-- 
-----------
Tim Gardner
Canonical, Inc