NACK/Cmnt: [SRU][J/F][PATCH 0/1] CVE-2024-27012

[Manuel Diewald]

On Thu, Aug 01, 2024 at 01:03:16PM +0200, Hannah Peuckmann wrote:
> [Impact]
> The existing code in nf_tables has an issue where set elements are not properly restored when the delete set operation fails.
> 
> [Fix]
> This patch ensures that all set elements are correctly handled during the delete operation, maintaining the integrity of the nf_tables.
> 
> Noble: done
> Jammy: applied, fixed context conflicts
> Focal: applied, fixed context conflicts
> Bionic: not affected
> Xenial: not affected
> Trusty: not affected
> 
> Focal and Jammy are missing the following commit:
> 0e1ea651c9717dd ("netfilter: nf_tables: shrink memory consumption of set elements")
> 
> This introduced context conflicts in net/netfilter/nf_tables_api.c but
> they aren't related to the fix and are relatively straightforward to resolve.
> 
> [Test Case]
> 
> Compiled and booted.
> 
> [Where problems could occur]
> 
> This fix affects those who use the nf_tables in netfilter. An issue with this fix could result in unexpected behaviour
> or inconsistencies in the netfilter tables.
> 
> 
> Pablo Neira Ayuso (1):
>   netfilter: nf_tables: restore set elements when delete set fails
> 
>  net/netfilter/nf_tables_api.c  | 25 +++++++++++++++++++++++++
>  net/netfilter/nft_set_bitmap.c |  4 +---
>  net/netfilter/nft_set_hash.c   |  8 ++------
>  net/netfilter/nft_set_rbtree.c |  4 +---
>  4 files changed, 29 insertions(+), 12 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

The jammy patch is not in reply to the cover letter and hence not part
of this thread. Please re-submit everything as one thread. Some tooling
might rely on it to work properly, e.g. mine. :)

-- 
 Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240801/ac3effa4/attachment.sig>