ACK: [SRU] [jammy:linux-xilinx-zynqmp v2 0/1] Update IMX547 out-of-tree driver code

[Manuel Diewald]

On Mon, Aug 05, 2024 at 12:02:55PM -0400, Portia Stephens wrote:
> [ Impact ]
> 
> * With current use of non-devm functions the user is responsible for freeing the resources and since this is not handled currently the driver does not probe the sensor on the second load, since resources are not freed.
> 
> * Here is a dmesg snippet:
> 
> On first load
> ubuntu at kria:~$ sudo dmesg | grep imx547
> [ 72.621037] imx547: module is from the staging directory, the quality is unknown, you have been
> warned.
> [ 72.628992] imx547 7-001a: imx547 : imx547 probe success !
> On second load:
> ubuntu at kria:~$ sudo dmesg | grep imx547
> [ 312.319586] imx547 7-001a: GT TRX Reset GPIO not setup in DT
> [ 312.325487] imx547: probe of 7-001a failed with error -16
> 
> * New implementation of using device managed ie devm_* functions ensures that resource is
> automatically removed when driver is unloaded.
> 
> [ Test Plan ]
> 
> * Xilinx will verify the functionality when testing kernel is provided.
> 
> [ Where problems could occur ]
> 
> * Since freeing of the GPIO resource is not explicitly handled in current implementation
> the driver fails to probe the sensor and fails to add it to media subsystem.
> 
> [ Other Info ]
> 
> * Patch/Tag to be included : https://github.com/Xilinx/mv-camera-sensor-module/releases/tag/v0.3
> * BugLink: https://bugs.launchpad.net/bugs/2076108
> 
> Portia Stephens (1):
>   UBUNTU: SAUCE: imx547 : Used devm_* resource management functions
>     instead of gpiod_*
> 
>  ubuntu/staging/xilinx-mv-camera-sensor-module/imx547.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald at canonical.com>

-- 
 Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240805/b66be549/attachment.sig>