ACK: [SRU][J/F][PATCH v4 0/1] CVE-2024-27012

[Manuel Diewald]

On Fri, Aug 09, 2024 at 02:25:34PM +0200, Hannah Peuckmann wrote:
> [Impact]
> The existing code in nf_tables has an issue where set elements are not properly restored when the delete set operation fails.
> 
> [Fix]
> This patch ensures that all set elements are correctly handled during the delete operation, maintaining the integrity of the nf_tables.
> 
> Noble: done
> Jammy: applied, fixed context conflicts
> Focal: applied, fixed context conflicts
> Bionic: not affected
> Xenial: not affected
> Trusty: not affected
> 
> Focal and Jammy are missing the following commit:
> 0e1ea651c9717dd ("netfilter: nf_tables: shrink memory consumption of set elements")
> 
> This introduced context conflicts in nf_tables_api.c and for jammy also in nft_set_pipapo.c, but
> they aren't related to the fix and are relatively straightforward to resolve.
> 
> [v4 changes]
> 
> I adjusted the context in nft_map_catchall_deactivate again to handle elem.priv correctly.
> elem.priv is now being set first and passed to nft_setelem_data_deactivate afterwards.
> 
> 
> [Test Case]
> 
> Compiled and booted.
> 
> [Where problems could occur]
> 
> This fix affects those who use the nf_tables in netfilter. An issue with this fix could result in unexpected behaviour
> or inconsistencies in the netfilter tables.
> 
> 
> Pablo Neira Ayuso (1):
>   netfilter: nf_tables: restore set elements when delete set fails
> 
>  net/netfilter/nf_tables_api.c  | 25 +++++++++++++++++++++++++
>  net/netfilter/nft_set_bitmap.c |  4 +---
>  net/netfilter/nft_set_hash.c   |  8 ++------
>  net/netfilter/nft_set_rbtree.c |  4 +---
>  4 files changed, 29 insertions(+), 12 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Looks very good now! Thank you for addressing all my nitpicks.

Acked-by: Manuel Diewald <manuel.diewald at canonical.com>

-- 
 Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240813/db0bdba5/attachment-0001.sig>