NACK/Cmnt: [SRU][O/N][PATCH 0/1] reenable libtraceevent

Stefan Bader stefan.bader at canonical.com
Thu Aug 15 12:29:10 UTC 2024


On 14.08.24 22:39, Bethany Jamison wrote:
> Reenable libtraceevent to fix LP#2076190 - effectively
> revert commit 92550b568d (UBUNTU: [Packaging] perf: build without
> libtraceevent)
> 
> Bethany Jamison (1):
>    UBUNTU: [Packaging] perf: reenable libtraceevent
> 
>   debian/rules.d/2-binary-arch.mk  | 4 ++--
>   debian/rules.d/3-binary-indep.mk | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 

Rejected for the following reasons:
- For one the patches contain no BugLinks
- The other issue to me is that it is not clear why it was disabled and what
   impact that might have when this gets enabled again...
   What is the tradeoff?

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240815/c9e7257d/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240815/c9e7257d/attachment-0001.sig>


More information about the kernel-team mailing list